Fixing linting rules and CI configuration.

Author: krulis-martin

.eslintrc

@@ -65,7 +65,7 @@
       ".less$"
     ],
     "react": {
-      "version": 16.2.0
+      "version": 17.0.2
     }
   },
   "globals": {

.github/workflows/ci.yml

@@ -4,29 +4,31 @@ on: [push, pull_request]
 
 jobs:
   tests:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
-        node-version: ['14']
+        node-version: ['18']
     steps:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-        
-    - run: npm install
-    - run: npm test
+    - run: npm install -g yarn
+    - run: corepack enable
+    - run: yarn install
+    - run: yarn test
 
   lint:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
-        node-version: ['14']
+        node-version: ['18']
     steps:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-        
-    - run: npm install
-    - run: npm run lint
+    - run: npm install -g yarn
+    - run: corepack enable
+    - run: yarn install
+    - run: yarn lint

package.json

@@ -126,6 +126,7 @@
     "eslint-config-standard-react": "11.0.1",
     "eslint-plugin-babel": "^5.3.1",
     "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-n": "latest",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "^6.0.0",
     "eslint-plugin-react": "^7.30.1",

src/components/Groups/ResultsTable/ResultsTable.js

@@ -405,7 +405,7 @@ class ResultsTable extends Component {
       const data = {
         id: user.id,
         selected: !showOnlyMe && user.id === loggedUser.id,
-        user: user,
+        user,
         total: userStats && userStats.points,
         buttons: renderActions && hasPermissions(group, 'update') ? renderActions(user.id) : '',
         // actually 'update' is not the right premission, but its sufficiently close :)

src/components/SystemMessages/MessagesList/MessagesList.js

@@ -98,9 +98,7 @@ class MessagesList extends Component {
       <>
         <FilterSystemMessagesForm
           onSubmit={({ showAll }) => {
-            this.setState({
-              showAll: showAll,
-            });
+            this.setState({ showAll });
             return Promise.resolve();
           }}
           initialValues={{ showAll: this.state.showAll }}

src/components/icons/Icon.js

@@ -31,7 +31,7 @@ const Icon = ({
         [style.largeGapLeft]: largeGapLeft,
         [style.largeGapRight]: largeGapRight,
         [style.disabled]: disabled,
-        timid: timid,
+        timid,
         clickable: Boolean(onClick || onDoubleClick),
       })}
       onClick={onClick}

src/redux/modules/auth.js

@@ -151,7 +151,7 @@ const auth = (accessToken, instanceId, now = Date.now()) => {
           jwt: accessToken,
           accessToken: decodedToken,
           userId: getUserId(decodedToken),
-          instanceId: instanceId,
+          instanceId,
         })
       : fromJS({
           status: {},

yarn.lock

@@ -4711,6 +4711,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"builtins@npm:^5.0.1":
+  version: 5.0.1
+  resolution: "builtins@npm:5.0.1"
+  dependencies:
+    semver: ^7.0.0
+  checksum: 66d204657fe36522822a95b288943ad11b58f5eaede235b11d8c4edaa28ce4800087d44a2681524c340494aadb120a0068011acabe99d30e8f11a7d826d83515
+  languageName: node
+  linkType: hard
+
 "bytes@npm:3.0.0":
   version: 3.0.0
   resolution: "bytes@npm:3.0.0"
@@ -6885,6 +6894,18 @@ __metadata:
   languageName: node
   linkType: hard
 
+"eslint-plugin-es@npm:^4.1.0":
+  version: 4.1.0
+  resolution: "eslint-plugin-es@npm:4.1.0"
+  dependencies:
+    eslint-utils: ^2.0.0
+    regexpp: ^3.0.0
+  peerDependencies:
+    eslint: ">=4.19.1"
+  checksum: 26b87a216d3625612b1d3ca8653ac8a1d261046d2a973bb0eb2759070267d2bfb0509051facdeb5ae03dc8dfb51a434be23aff7309a752ca901d637da535677f
+  languageName: node
+  linkType: hard
+
 "eslint-plugin-import@npm:^2.26.0":
   version: 2.26.0
   resolution: "eslint-plugin-import@npm:2.26.0"
@@ -6908,6 +6929,24 @@ __metadata:
   languageName: node
   linkType: hard
 
+"eslint-plugin-n@npm:latest":
+  version: 15.2.4
+  resolution: "eslint-plugin-n@npm:15.2.4"
+  dependencies:
+    builtins: ^5.0.1
+    eslint-plugin-es: ^4.1.0
+    eslint-utils: ^3.0.0
+    ignore: ^5.1.1
+    is-core-module: ^2.9.0
+    minimatch: ^3.1.2
+    resolve: ^1.10.1
+    semver: ^7.3.7
+  peerDependencies:
+    eslint: ">=7.0.0"
+  checksum: dd651651ab76120e45707ee968d846e3ffffb42d1035792fdef6d3b0dcfddf3673bc6a09cb2fac8c5f1d081f14f2a67fc52295d5ed1d2edfb5beead93284eaac
+  languageName: node
+  linkType: hard
+
 "eslint-plugin-node@npm:11.1.0":
   version: 11.1.0
   resolution: "eslint-plugin-node@npm:11.1.0"
@@ -12571,6 +12610,7 @@ __metadata:
     eslint-config-standard-react: 11.0.1
     eslint-plugin-babel: ^5.3.1
     eslint-plugin-import: ^2.26.0
+    eslint-plugin-n: latest
     eslint-plugin-node: 11.1.0
     eslint-plugin-promise: ^6.0.0
     eslint-plugin-react: ^7.30.1
@@ -13392,25 +13432,25 @@ __metadata:
   languageName: node
   linkType: hard
 
-"semver@npm:^7.3.5":
-  version: 7.3.5
-  resolution: "semver@npm:7.3.5"
+"semver@npm:^7.0.0, semver@npm:^7.3.7":
+  version: 7.3.7
+  resolution: "semver@npm:7.3.7"
   dependencies:
     lru-cache: ^6.0.0
   bin:
     semver: bin/semver.js
-  checksum: 5eafe6102bea2a7439897c1856362e31cc348ccf96efd455c8b5bc2c61e6f7e7b8250dc26b8828c1d76a56f818a7ee907a36ae9fb37a599d3d24609207001d60
+  checksum: 2fa3e877568cd6ce769c75c211beaed1f9fce80b28338cadd9d0b6c40f2e2862bafd62c19a6cff42f3d54292b7c623277bcab8816a2b5521cf15210d43e75232
   languageName: node
   linkType: hard
 
-"semver@npm:^7.3.7":
-  version: 7.3.7
-  resolution: "semver@npm:7.3.7"
+"semver@npm:^7.3.5":
+  version: 7.3.5
+  resolution: "semver@npm:7.3.5"
   dependencies:
     lru-cache: ^6.0.0
   bin:
     semver: bin/semver.js
-  checksum: 2fa3e877568cd6ce769c75c211beaed1f9fce80b28338cadd9d0b6c40f2e2862bafd62c19a6cff42f3d54292b7c623277bcab8816a2b5521cf15210d43e75232
+  checksum: 5eafe6102bea2a7439897c1856362e31cc348ccf96efd455c8b5bc2c61e6f7e7b8250dc26b8828c1d76a56f818a7ee907a36ae9fb37a599d3d24609207001d60
   languageName: node
   linkType: hard