Skip to content

Commit 1ff664c

Browse files
committed
Adding current URL for the return in the extension URLs.
1 parent 57b863a commit 1ff664c

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

src/components/layout/Sidebar/Sidebar.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ const extensionClickHandler = lruMemoize(fetchExtensionUrl => ev => {
5353
const extension = ev.currentTarget.dataset.extension;
5454
const instance = ev.currentTarget.dataset.instance;
5555
const locale = ev.currentTarget.dataset.locale;
56-
fetchExtensionUrl(extension, instance, locale).then(({ value: url }) => window.location.assign(url));
56+
const returnUrl = window.location.href;
57+
fetchExtensionUrl(extension, instance, locale, returnUrl).then(
58+
({ value: url }) => url && window.location.assign(url)
59+
);
5760
}
5861
});
5962

src/containers/SidebarContainer/SidebarContainer.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export default connect(
1616
notifications: notificationsSelector(state),
1717
}),
1818
dispatch => ({
19-
fetchExtensionUrl: (extension, instance, locale) => dispatch(fetchExtensionUrl(extension, instance, locale)),
19+
fetchExtensionUrl: (extension, instance, locale, returnUrl = '') =>
20+
dispatch(fetchExtensionUrl(extension, instance, locale, returnUrl)),
2021
})
2122
)(Sidebar);

src/redux/modules/app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ export const setLang = createAction(actionTypes.SET_LANG, lang => ({
2222
export const newPendingFetchOperation = createAction(actionTypes.NEW_PENDING_FETCH_OPERATION);
2323
export const completedFetchOperation = createAction(actionTypes.COMPLETED_FETCH_OPERATION);
2424

25-
export const fetchExtensionUrl = (extension, instance, locale) =>
25+
export const fetchExtensionUrl = (extension, instance, locale, returnUrl = '') =>
2626
createApiAction({
2727
type: actionTypes.EXTENSION_URL,
2828
method: 'GET',
29-
endpoint: `/extensions/${extension}/${instance}?locale=${locale}`,
29+
endpoint: `/extensions/${encodeURIComponent(extension)}/${encodeURIComponent(instance)}?locale=${encodeURIComponent(locale)}&return=${encodeURIComponent(returnUrl)}`,
3030
meta: { extension, instance, locale },
3131
});
3232

0 commit comments

Comments
 (0)