-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GIF support for animated lock screen #262
base: master
Are you sure you want to change the base?
Conversation
85a0f71
to
953ccad
Compare
@sh1r4s3 Can you fix the build files as well? |
953ccad
to
e174455
Compare
@Raymo111 I updated the Dockerfile to include |
@Raymo111 From the build log it is seems that it doesn't use an updated version of |
@sh1r4s3 oh we're not using Travis... Upstream used to use it but they switched to GitHub Actions recently and we've been using GitHub Actions for a while now. You'll want to edit the |
e174455
to
6bb4dca
Compare
@Raymo111 got it, thanks! I updated these files. Could you please trigger the build again :) |
@Raymo111 seems that now everything is OK :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested. Also, mind explaining what read_gif_image
does? I'm really not sure. Lastly, please update the manpage as well to document that GIFs are now supported (update the date to Sept 2022 as well). Great work and thanks for contributing, keep it up!
Btw @sh1r4s3 What did you mean by this? |
32eba9b
to
ed51af5
Compare
@Raymo111 Thanks for the review! I implemented your suggestions and updated the man page.
Sure. Basically it do the following:
|
Also I think it is worth to mention that this code doesn't upscale GIF images. A user should find a gif file that suits its display's resolution or upscale it with the of other utility, like |
Hi @Raymo111, I just wanted to kindly remind about this PR :) |
ed51af5
to
5774f65
Compare
Use gif_lib to read a GIF file [1] and show animated lock screen. Currently it supports only 0-2 disposal methods. [1] https://www.w3.org/Graphics/GIF/spec-gif89a.txt
Multiplication result converted to larger type
1fd50b6
to
0f9e957
Compare
Description
Use gif_lib to read a GIF file and show animated lock screen.
Currently it supports only 0-2 disposal methods.
Screenshots/screencaps
Release notes
Added support for animated GIF images.