Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White blink before image display on lock #166

Closed
romzie opened this issue May 30, 2020 · 3 comments
Closed

White blink before image display on lock #166

romzie opened this issue May 30, 2020 · 3 comments

Comments

@romzie
Copy link

romzie commented May 30, 2020

This issue is a....

[ ] Bug
[X] Other kind of issue (Please describe in detail)

Current Behavior

Command used: i3lock -i /tmp/img.png
When using i3lock apt package : works as expected (see gif)
When installing i3lock-color : there is a white blink before the image display (see gif)

Expected Behavior

No white blink with i3lock-color

Reproduction Instructions

I am using Ubuntu 20.04 (DE is Regolith 1.4, WM is i3-gaps)
Installed i3lock using sudo apt install i3lock, then recorded the first gif above
Then cloned this repo, built and installed it from source before recording the second gif
Image used was generated using
scrot -z -o /tmp/img.jpg && convert -scale 20% -scale 500% /tmp/img.jpg /tmp/img.png

Environment

Output of i3lock --version:

i3lock version: version 2.12.c.4 (2020-05-18)

Where'd you get i3lock-color from?

[ ] AUR package (which one?)
[X] Built from source yourself (commit 720e2b4cfce703b870788de283be21e50c22096f)
[ ] Other (Please describe in detail)
@Raymo111
Copy link
Owner

@romzie i3lock-color has to render a bunch of stuff more than i3lock, so it's showing the default background color (white) for an instant (images can have transparency so the bg color has to be rendered first). The best way to fix this is to set the background color to something unnoticeable, like black (-c 000000). If there's no transparency in your image or you don't mind transparency then you can go for a transparent bg color (-c 00000000). Hope this helps!

Note to self: probably related to #159.

@romzie
Copy link
Author

romzie commented May 31, 2020

Thank you for the quick reply, using a transparent background color indeed is enough for my use case. We can close this issue now I guess.

@Raymo111
Copy link
Owner

No worries. Awesome, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants