From 382cc2487bd2805c5ded83109a6c984c1aa31add Mon Sep 17 00:00:00 2001 From: Ben Henning Date: Thu, 15 May 2025 18:17:03 +0000 Subject: [PATCH 1/2] fix: Re-enable tests. This uses a workaround to ensure SVGElement is actually present in the global namespace when running these tests. --- .../test/shadow_block_converter_test.mocha.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/shadow-block-converter/test/shadow_block_converter_test.mocha.js b/plugins/shadow-block-converter/test/shadow_block_converter_test.mocha.js index e25374eaf8..999ba36c6e 100644 --- a/plugins/shadow-block-converter/test/shadow_block_converter_test.mocha.js +++ b/plugins/shadow-block-converter/test/shadow_block_converter_test.mocha.js @@ -11,7 +11,7 @@ const {shadowBlockConversionChangeListener} = require('../src/index'); const assert = chai.assert; -suite.skip('shadowBlockConversionChangeListener', function () { +suite('shadowBlockConversionChangeListener', function () { /** * Create a parent block with an unconnected value connection. * @param {Blockly.Workspace} workspace The workspace to use. @@ -38,6 +38,8 @@ suite.skip('shadowBlockConversionChangeListener', function () { '
', {pretendToBeVisual: true}, ); + // See https://github.com/google/blockly-samples/issues/2528 for context. + global.SVGElement = window.SVGElement; this.workspace = Blockly.inject('blocklyDiv'); this.workspace.addChangeListener(shadowBlockConversionChangeListener); From 1a63691ae0bad96a82887f339f514b1e5f223e26 Mon Sep 17 00:00:00 2001 From: Ben Henning Date: Thu, 15 May 2025 18:21:19 +0000 Subject: [PATCH 2/2] chore: Empty commit to re-trigger CI.