Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rasa train and rasa run with new model architecture #9604

Closed
4 tasks
wochinge opened this issue Sep 10, 2021 · 1 comment · Fixed by #9671, #9747 or #9803
Closed
4 tasks

Integrate rasa train and rasa run with new model architecture #9604

wochinge opened this issue Sep 10, 2021 · 1 comment · Fixed by #9671, #9747 or #9803
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/8 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@wochinge
Copy link
Contributor

Description
It's time for a big step 🔥 After having migrated all components, implementing rasa.engine, creating the new components for the graph, and implementing the graph generation using the recipes it is time to integrate everything together.

Definition of Done

  • rasa train trains using the graph architecture (+ the variants like rasa train nlu/core)
  • rasa run loads graph architecture models and is able to make predictions with it
  • The test suit passes
  • the model accuracy didn't drop (I think we need to do that as part of this one as it will be a pain to find the issue later on; also not expecting any issues here)

Things which don't need to be done

  • Making sure all no longer needed code is deleted (we can do that separately)
  • Assessing / improving performance will be a separate issue
@wochinge wochinge added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:rasa-3.0/architecture labels Sep 10, 2021
@TyDunn TyDunn added priority:high effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Sep 10, 2021
@aeshky aeshky added effort:atom-squad/8 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. and removed effort:atom-squad/8 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Sep 10, 2021
@joejuzl joejuzl added effort:atom-squad/8 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. and removed effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Sep 10, 2021
@wochinge
Copy link
Contributor Author

wochinge commented Sep 16, 2021

  • fix caching of empty resource
  • fix recipe tests
  • not load predict thing as part of train
  • rasa train @wochinge
  • rasa predict @joejuzl (maybe: HTTPInterpreter 😁 )
  • fix recipes tests @wochinge
  • fix check logging @joejuzl

Ideas:

  • targets for prediction should be in metadata
  • put cli + language in execution context for train

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/8 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
4 participants