Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy union-attr error code #9096

Closed
2 tasks done
wochinge opened this issue Jul 12, 2021 · 1 comment · Fixed by #10942
Closed
2 tasks done

Enable mypy union-attr error code #9096

wochinge opened this issue Jul 12, 2021 · 1 comment · Fixed by #10942
Assignees
@ancalita
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Jul 12, 2021 •
edited by ancalita
Loading

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 91

Definition of Done:

  • enable mypy checks for [union-attr]
  • all existing [union-attr] issues are fixed
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 12, 2021
@wochinge wochinge mentioned this issue Jul 12, 2021
Closed
2 tasks
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@jupyterjazz jupyterjazz removed the stale label Jan 27, 2022
@ancalita ancalita self-assigned this Feb 23, 2022
@ancalita ancalita mentioned this issue Feb 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancalita ancalita

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable union-attr mypy check and fix issues RasaHQ/rasa
3 participants
@wochinge @ancalita @jupyterjazz