Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Fix operator #9058

Closed
2 tasks done
twerkmeister opened this issue Jul 7, 2021 · 0 comments · Fixed by #9062
Closed
2 tasks done

mypy: Fix operator #9058

twerkmeister opened this issue Jul 7, 2021 · 0 comments · Fixed by #9062
Assignees
@twerkmeister
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@twerkmeister
Copy link
Contributor

twerkmeister commented Jul 7, 2021 •
edited
Loading

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 44

Definition of Done:

  • enable mypy checks for operator
  • all existing operator issues are fixed
@twerkmeister twerkmeister added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jul 7, 2021
@twerkmeister twerkmeister mentioned this issue Jul 7, 2021
Merged
2 tasks
@twerkmeister twerkmeister self-assigned this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twerkmeister twerkmeister

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed mypy operator error type RasaHQ/rasa
1 participant
@twerkmeister