Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sara and insurance and retail starter packs to regression test configs. #8676

Closed
2 tasks done
kedz opened this issue May 12, 2021 · 5 comments
Closed
2 tasks done
Assignees
Labels
area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments area:rasa-oss/ml 👁 All issues related to machine learning research:code-improvement research:regression-tests type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@kedz
Copy link
Contributor

kedz commented May 12, 2021

Description of Problem:
Add Sara, insurance-demo, retail-demo datasets to regression test configs after the following issue has been resolved.

Overview of the Solution:
Edit the dataset_config_mapping.json in the RasaHQ/training-data repo.
The modified Sara dataset should be:

    "Sara": {
      "path": "public/Sara",
      "language": "en",
      "domain": "domain.yml"
    },

the following should be added:

    "retail-demo": {
      "repository": "RasaHQ/retail-demo",
      "language": "en",
      "domain": "domain.yml",
      "train": "data",
      "test": "tests"
    },
    "insurance-demo": {
      "repository": "RasaHQ/insurance-demo",
      "language": "en",
      "domain": "domain.yml",
      "train": "data",
      "test": "tests"
    },

Examples (if relevant):

Blockers (if relevant):
the following issue

  • waiting for updated Sara data PR to be merged which includes a domain.yml

Definition of Done:

  • dataset_config_mapping.json is modified as specified above.
  • Verify that the model regression tests continue to work with these two new test data sets
@kedz kedz added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments area:rasa-oss/ml 👁 All issues related to machine learning labels May 12, 2021
@kedz
Copy link
Contributor Author

kedz commented May 28, 2021

This blocking issue has been resolved. This can be implemented now. Still waiting on Sara training data PR to be merged (@samsucik 's comment below), which includes a domain.yml which is necessary to run core regression tests.

@samsucik
Copy link
Contributor

samsucik commented Jun 9, 2021

Fyi I've added Sara as part of this training-data PR (waiting to be merged).

@alopez
Copy link
Contributor

alopez commented Jul 23, 2021

assignee: @kedz
reviewer: @aeshky

@kedz
Copy link
Contributor Author

kedz commented Jul 23, 2021

This requires updating following repos:

  • retail-demo (PR) -- update domain to 2.8
  • insurance-demo (PR) -- update domain to 2.8
  • training-data (PR) -- update config to point to starter pack repos, depends on merging the first 2 PRs.

@kedz
Copy link
Contributor Author

kedz commented Jul 28, 2021

This issue has been resolved now that this PR has been merged. Working regression test results are here.

@kedz kedz closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments area:rasa-oss/ml 👁 All issues related to machine learning research:code-improvement research:regression-tests type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

5 participants