-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename non-expressive variables #8521
Comments
Exalate commented: sara-tagger commented: Thanks for submitting this feature request |
Exalate commented: koernerfelicia commented: Hi @ericoBandeira I see you've already linked a pull request! Thank you for that, my colleague will take a look at it. Please be sure to take care of the failing test – looks like you need to reformat the file. Read more about how to do this locally here. |
Exalate commented: stale[bot] commented: This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
➤ Maxime Verger commented: 💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS. From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue! ➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569. |
Description of Problem: on the files:
.../rasa/core/tracker_store.py
;.../rasa/utils/io.py
;/rasa/core/channels/mattermost.py
.has some variables with a non expressive name.
Overview of the Solution: Changing variables that are just letters to names that express exactly what the variable represents.
The text was updated successfully, but these errors were encountered: