Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non expressive variable name on .../shared/ files #8520

Closed
rafaelteodosio opened this issue Apr 22, 2021 · 4 comments
Closed

Non expressive variable name on .../shared/ files #8520

rafaelteodosio opened this issue Apr 22, 2021 · 4 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@rafaelteodosio
Copy link
Contributor

rafaelteodosio commented Apr 22, 2021 •
edited by rasabot-exalate
Loading

Description of Problem: on the files .../shared/core/training_data/visualization.py , .../shared/core/slots.py, shared/nlu/training_data/message.py has some variables with a non expressive name.

Overview of the Solution: Change the name from i or d to something more expressive.
@rafaelteodosio rafaelteodosio added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Apr 22, 2021
@rafaelteodosio rafaelteodosio mentioned this issue Apr 22, 2021
Closed
4 tasks
@sara-tagger
Copy link
Collaborator

sara-tagger commented Apr 22, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

sara-tagger commented:

Thanks for submitting this feature request

🚀
@lty4 will get back to you about it soon!

✨

@erohmensing
Copy link
Contributor

erohmensing commented Apr 28, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

erohmensing commented:

Thanks for the PR!

@TyDunn TyDunn added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels May 26, 2021
@stale
Copy link

stale bot commented Jan 9, 2022 •
edited by rasabot-exalate
Loading

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@TyDunn TyDunn removed the stale label Jan 27, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 15, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed type:maintenance labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss_:ferris_wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss_:ferris_wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change non expressive variable name on shared files FGA-GCES/rasa
6 participants
@m-vdb @TyDunn @erohmensing @rafaelteodosio @sara-tagger @rasabot-exalate