Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Fix no-redef, valid-type, and type-var #8240

Closed
2 tasks done
wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8318
Closed
2 tasks done

mypy: Fix no-redef, valid-type, and type-var #8240

wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8318
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Mar 18, 2021 •
edited
Loading

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 15

Definition of Done:

  • enable mypy checks for no-redef, valid-type and type-var
  • all existing no-redef, valid-type and type-var issues are fixed
@wochinge wochinge added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Mar 18, 2021
@joejuzl joejuzl assigned joejuzl and alwx and unassigned joejuzl Mar 22, 2021
@wochinge wochinge assigned wochinge and unassigned alwx Mar 26, 2021
@wochinge wochinge mentioned this issue Mar 26, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable mypy checks: no-redef, valid-type, type-var RasaHQ/rasa
3 participants
@alwx @joejuzl @wochinge