-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for histogram plotting #7912
Comments
Hi, has this issue been solved? |
@ericoBandeira I was just about to pick it up. Do you want to do it? |
@JEM-Mosig I would like to solve this issue! thank you so much |
@ericoBandeira Ok, great! Go ahead :) You can assign me to review your PR when you're ready. |
@JEM-Mosig Hello! I'm working with @ericoBandeira and I have a question, where should the test be created? as |
@santosm46 @ericoBandeira The test should be in a new |
@santosm46 @ericoBandeira How is this coming along? |
Hi @JEM-Mosig |
Oh, ok. I'll pick it up then. |
Looking into it, I just notice that the plot is missing some data (cutoffs are wrong). E.g. for:
the left histogram only shows two bars, even though it should be three. Will fix this with this issue, too. |
Description of Problem:
Currently there are no tests for histogram plotting inside
rasa/utils/plotting.py
(def plot_histogram
). These should be added, specifically related to the logic of creation of bins.Overview of the Solution:
Tests for the above function
The text was updated successfully, but these errors were encountered: