Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the logic of retraining models #7581

Closed
Ghostvv opened this issue Dec 17, 2020 · 3 comments
Closed

change the logic of retraining models #7581

Ghostvv opened this issue Dec 17, 2020 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@Ghostvv
Copy link
Contributor

Ghostvv commented Dec 17, 2020

currently if smth changed, we most likely retrain both NLU and core models (see #7129 for details). However in majority of the cases this retraining is unnecessary. Instead of comparing data, we should compare featurizer outputs and retrain only if they changed, not the data

@Ghostvv Ghostvv added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Dec 17, 2020
@alwx alwx added area:rasa-oss/ml 👁 All issues related to machine learning area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components labels Jan 27, 2021
@twerkmeister
Copy link
Contributor

Hey @Ghostvv, I read through the issue #7129 that you linked. However, it is very difficult for me to understand what needs to be done here, as the issue is 3 months old and I don't know what has potentially changed since then. Are there any problems mentioned in that old issue that are still around?

What are examples of these changes that don't require a full retraining and how common are they? How much time does it cost you?

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Mar 17, 2021

there are many variants, for example when you add some nlu examples that don't contain new words, you don't actually need to retrain core model.

Giving current architecture, I don't think it is easy implement right now. This is issue should be part of bigger refactoring where featurizers become independent component from nlu. cc @wochinge and @joejuzl

@wochinge
Copy link
Contributor

wochinge commented Nov 5, 2021

fixed with Rasa Open Source 3.0

@wochinge wochinge closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

4 participants