Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn feature combining in TED/DIET into re-usable layers #7187

Closed
samsucik opened this issue Nov 5, 2020 · 0 comments · Fixed by #7589
Closed

Turn feature combining in TED/DIET into re-usable layers #7187

samsucik opened this issue Nov 5, 2020 · 0 comments · Fixed by #7589
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@samsucik
Copy link
Contributor

samsucik commented Nov 5, 2020

We want to simplify the code of TED and DIET by factoring out the combining of different feature types into re-usable model components (layers).

The implementation of TransformerRasaModel._combine_sparse_dense_features and TransformerRasaModel._combine_sequence_sentence_features will be made into re-usable layers inheriting from tf.keras.layers.Layer. This way, the layers can be used more generally, not just in Transformer models, and the architecture implementation of TEDPolicy and DIETClassifier will be simplified, better reflecting the high-level schemata of the models' architectures.

Actual work happens in #7589.

@samsucik samsucik self-assigned this Nov 5, 2020
@samsucik samsucik added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Nov 5, 2020
@samsucik samsucik changed the title Turn feature concatenation in TED/DIET into re-usable layers Turn feature combining in TED/DIET into re-usable layers Nov 5, 2020
@tmbo tmbo added area:rasa-oss/ml 👁 All issues related to machine learning and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Nov 17, 2020
@alwx alwx added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants