Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Telegram channel with a different library #6814

Closed
akelad opened this issue Sep 28, 2020 · 1 comment
Closed

Rewrite Telegram channel with a different library #6814

akelad opened this issue Sep 28, 2020 · 1 comment
Assignees
@rgstephens
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@akelad
Copy link
Contributor

akelad commented Sep 28, 2020

Description of Problem:
The current package python-telegram-bot uses a vendored package of urllib3, which hasn't been updated since 2017 and therefore has some security vulnerabilities. See issue for details: python-telegram-bot/python-telegram-bot#2097

Overview of the Solution:
We should rewrite the telegram channel to use this package instead: https://github.com/eternnoir/pyTelegramBotAPI
@akelad akelad added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Sep 28, 2020
@rgstephens rgstephens mentioned this issue Oct 3, 2020
Merged
4 tasks
@tmbo tmbo added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Nov 17, 2020
@wochinge
Copy link
Contributor

closed by https://github.com/RasaHQ/rasa/pull/6889/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgstephens rgstephens

Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rgstephens @tmbo @wochinge @akelad