Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running socket client throws errors during Interactive Learning #4487

Closed
erohmensing opened this issue Sep 19, 2019 · 16 comments
Closed

Running socket client throws errors during Interactive Learning #4487

erohmensing opened this issue Sep 19, 2019 · 16 comments
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework difficulty:easy 🦋 help wanted type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@erohmensing
Copy link
Contributor

erohmensing commented Sep 19, 2019

The socket client points to the rasa server, and if you don't change the defaults, rasa interactive runs on the same port as rasa run – therefore, socket is listening for events during rasa interactive. However, since the socket endpoint is not available during this, it leads to an error:

[2019-08-01 11:45:37 +0200] [23200] [ERROR] Exception occurred while handling uri: 'http://localhost:5005/socket.io/?EIO=3&transport=polling&t=MnCaWoQ'
Traceback (most recent call last):
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\app.py", line 893, in handle_request
handler, args, kwargs, uri = self.router.get(request)
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\router.py", line 407, in get
return self._get(request.path, request.method, "")
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\router.py", line 469, in _get
raise NotFound("Requested URL {} not found".format(url))
sanic.exceptions.NotFound: Requested URL /socket.io/ not found
[2019-08-01 11:45:37 +0200] [23200] [ERROR] Exception occurred while handling uri: 'http://localhost:5005/socket.io/?EIO=3&transport=polling&t=MnCaXHh'
Traceback (most recent call last):
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\app.py", line 893, in handle_request
handler, args, kwargs, uri = self.router.get(request)
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\router.py", line 407, in get
return self._get(request.path, request.method, "")
File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\sanic\router.py", line 469, in _get
raise NotFound("Requested URL {} not found".format(url))
sanic.exceptions.NotFound: Requested URL /socket.io/ not found
[2019-08-01 11:45:37 +0200] [23200] [ERROR] Exception occurred while handling uri: 'http://localhost:5005/socket.io/?EIO=3&transport=polling&t=MnCaXHi'

If we are in interactive mode, we should probably consume this exception since it's not relevant.

@soundaraj
Copy link

@erohmensing you can disconnect the socket client during the rasa interactive in progress, because socket client was retrying every seconds so this error was raised.

@erohmensing
Copy link
Contributor Author

@soundaraj I know you can, but it would be nice if it didn't raise the error since it shouldn't matter whether or not the client is connected while you're using interactive mode via the CLI

@erohmensing
Copy link
Contributor Author

This also happens if you are using a different connector, e.g. If you normally run with socket and then are testing in rasa shell. So we should only show the exception if the socketio channel is active.

@optimiztik
Copy link

I have the same exception " sanic.exceptions.NotFound: Requested URL /socket.io/ not found " . Do we have any workaround for this also when can we expect this issue to be closed.

@erohmensing
Copy link
Contributor Author

@optimiztik the exception does not cause any issues in the bot, it is only because your websocket it still open. The workaround, as @soundaraj said, is to disconnect the socket (close the page with the bot widget) while in interactive mode.

The issue is open as a help wanted issue, which means it is not top priority for us to work on (seeing as it is annoying, but doesn't cause buggy behavior) and will be closed if someone decides to take it on and surpress the warning.

@stale
Copy link

stale bot commented Feb 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Feb 9, 2020
@stale
Copy link

stale bot commented Feb 16, 2020

This issue has been automatically closed due to inactivity. Please create a new issue if you need more help.

@stale stale bot closed this as completed Feb 16, 2020
@erohmensing
Copy link
Contributor Author

Still valid, IMO

@erohmensing erohmensing reopened this Feb 19, 2020
@stale stale bot removed the status:stale label Feb 19, 2020
@imsaurabh50
Copy link

Hi @erohmensing !

I would like to work on this. May I please take this up?

@erohmensing
Copy link
Contributor Author

HI @MadPr0grammer! Sorry for missing your message. You absolutely can, i'll assign you to the issue.

@tmbo tmbo added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label May 12, 2020
@tmbo tmbo added the area:rasa-oss/channels 📞 Issues focused around rasas input and output channels label Nov 17, 2020
@UTkzhang
Copy link
Contributor

UTkzhang commented Dec 8, 2020

@erohmensing @tmbo can I take a look at this issue since it’s probably not actively worked on?

@erohmensing
Copy link
Contributor Author

Totally @UTkzhang. You're right, I haven't seen any PRs around it so should be safe to take up!

@erohmensing erohmensing assigned UTkzhang and unassigned imsaurabh50 Dec 11, 2020
@alwx alwx added area:rasa-oss/cli Issues focused on the rasa command-line-interface and removed area:rasa-oss/channels 📞 Issues focused around rasas input and output channels labels Jan 28, 2021
@TyDunn
Copy link
Contributor

TyDunn commented Jan 28, 2021

@shadow-blade-X Are you still working on this?

@m-vdb m-vdb added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss :ferris wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework difficulty:easy 🦋 help wanted type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR help wanted difficulty:easy 🦋 area:rasa-oss :ferris wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@shari-amalgamrx
Copy link

Hello.. Im facing the same issue. I have this deployed using a docker.
This is my sh file -
python -m rasa run actions -p 5055 & python -m rasa run --endpoints endpoints.yml -p 5002 --enable-api --credentials credentials.yml

Can someone please tell me how can handle this error?
Thank you

@UTkzhang UTkzhang removed their assignment Oct 18, 2022
@PedroLucasCM
Copy link
Contributor

Hi, is this issue still worth resolving?

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework difficulty:easy 🦋 help wanted type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests