Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split long modules / Improve directory structure #2811

Closed
wochinge opened this issue Dec 6, 2018 · 11 comments
Closed

Split long modules / Improve directory structure #2811

wochinge opened this issue Dec 6, 2018 · 11 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Dec 6, 2018

The project has some modules which are too long or have several classes in them which don't relate:

  • rasa_core/actions/action.py: 11 classes, > 490 lines
  • rasa_core/events/.__init__.py: 18 classes, > 950 lines
  • rasa_core/utils.py:4 classes, > 700 lines
  • rasa_core/evaluate.py: > 660 lines
  • tests/test_policies: > 600 lines

In case of the test modules it might also be worth to mirror the directory structure of the source code to ease finding tests.

@stale
Copy link

stale bot commented Mar 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@akelad
Copy link
Contributor

akelad commented Mar 7, 2019

@wochinge i guess this is still relevant?

@wochinge
Copy link
Contributor Author

wochinge commented Mar 7, 2019

yes. Also part of Rasa X

@akelad
Copy link
Contributor

akelad commented Mar 7, 2019

added the enhancement label so stalebot doesn't kill it :D

@tmbo tmbo transferred this issue from RasaHQ/rasa_core Mar 21, 2019
@akelad akelad added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Mar 27, 2019
@amn41
Copy link
Contributor

amn41 commented Jun 5, 2019

@wochinge what's the status?

@wochinge
Copy link
Contributor Author

wochinge commented Jun 5, 2019

Still has to be done. We made some progress for the utils, but not for the rest.

@tabergma tabergma added this to the Rasa 2.0 Ideas milestone Oct 2, 2019
@tabergma tabergma added the type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. label Oct 2, 2019
@wochinge wochinge added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Nov 18, 2019
@stale
Copy link

stale bot commented Feb 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mardntas
Copy link
Contributor

There is someone on it? Can I work on it?

@wochinge
Copy link
Contributor Author

@MarthaDs There is currently nobody working on it so it would be a great help if you could support us 🎉 One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes.

@mardntas
Copy link
Contributor

@MarthaDs There is currently nobody working on it so it would be a great help if you could support us One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes.

Alright :)

@wochinge wochinge removed the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Jan 27, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@rasabot-exalate rasabot-exalate added type:maintenance_:wrench: and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@rasabot-exalate rasabot-exalate added stale type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance_:wrench: labels Mar 21, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 21, 2022
@m-vdb m-vdb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

7 participants