-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split long modules / Improve directory structure #2811
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@wochinge i guess this is still relevant? |
yes. Also part of Rasa X |
added the enhancement label so stalebot doesn't kill it :D |
@wochinge what's the status? |
Still has to be done. We made some progress for the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There is someone on it? Can I work on it? |
@MarthaDs There is currently nobody working on it so it would be a great help if you could support us 🎉 One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes. |
Alright :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The project has some modules which are too long or have several classes in them which don't relate:
rasa_core/actions/action.py
: 11 classes, > 490 linesrasa_core/events/.__init__.py
: 18 classes, > 950 linesrasa_core/utils.py
:4 classes, > 700 linesrasa_core/evaluate.py
: > 660 linestests/test_policies
: > 600 linesIn case of the test modules it might also be worth to mirror the directory structure of the source code to ease finding tests.
The text was updated successfully, but these errors were encountered: