Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add activityResult to improve promise usability on Android #33

Closed
setoba1192 opened this issue Apr 19, 2023 · 2 comments
Closed

add activityResult to improve promise usability on Android #33

setoba1192 opened this issue Apr 19, 2023 · 2 comments

Comments

@setoba1192
Copy link
Contributor

setoba1192 commented Apr 19, 2023

Adds usability to then promise in the method NativeSettings.open to trigger some method when user gets back to screen

Platform:

Android

Current Behavior: Then promise execute immediately when call open method
New Behavior: Then promise wait to user gets back to screen

openSettingsTurnOnLocation = () => {
    const options = {
      optionAndroid: AndroidSettings.ApplicationDetails,
      optionIOS: IOSSettings.App,
    };

    NativeSettings.open(options).then((data) => {
      this.presentAlert('then execution', JSON.stringify(data), '');
    });
  };

I created a pull request to add this enhancement #31

@RaphaelWoude
Copy link
Owner

Hi. I think this would be a great addition to the plugin. I just commented on your PR.

@RaphaelWoude
Copy link
Owner

Live in v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants