Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty space for single item data results + broken scrollbar #255

Open
1 task done
RamiAwar opened this issue Jul 11, 2024 · 8 comments
Open
1 task done

Empty space for single item data results + broken scrollbar #255

RamiAwar opened this issue Jul 11, 2024 · 8 comments
Assignees
Labels
feature-request New feature or request good first issue Good for newcomers react tailwind

Comments

@RamiAwar
Copy link
Owner

RamiAwar commented Jul 11, 2024

Privileged issue

  • I'm @RamiAwar or he asked me directly to create an issue here.

Issue Content

Visually annoying edge-case, but also breaks the horizontall scrollbar (can't drag it anymore) which is annoying. Users will have to workaround with shift + scroll (horizontal scroll)

image

Here the scrollbar doesn't work:
image

More icons shifted badly:
image

@RamiAwar RamiAwar added the feature-request New feature or request label Jul 11, 2024
@RamiAwar RamiAwar changed the title Empty space for single item data results Empty space for single item data results + broken scrollbar Jul 11, 2024
@rohitt-gupta
Copy link

rohitt-gupta commented Aug 6, 2024

hi can i work on this issue?
if yes, please assign this to me
@RamiAwar

@RamiAwar
Copy link
Owner Author

RamiAwar commented Aug 7, 2024

of course 🙂

@RamiAwar
Copy link
Owner Author

RamiAwar commented Aug 7, 2024

fyi the storybook components are a bit broken, im fixing them in my current PR. I could merge part of it if you wanna use that for testing. I think it'll make your life easier cause then you control the inputs to those components.

@rohitt-gupta
Copy link

I just realised that the backend is written in python,
First i am exploring how to run the backend as i know very little python.
Second on which frontend route i can reproduce this issue?

@rohitt-gupta
Copy link

cc: @RamiAwar
image

@anthony2261
Copy link
Collaborator

@rohitt-gupta you'll need to install python 3.11 on your Windows machine, at time of writing 3.11.9 is the most recent patch version. Then, you'll need to tell poetry to use that version that you just installed, see the instructions here.

There is one other alternative, in case you have docker installed on your system, we have a dev docker compose. If you don't have docker installed (and that last sentence did not make sense to you), no worries, you can just ignore this option and stick to installing python 3.11 😄

@RamiAwar
Copy link
Owner Author

RamiAwar commented Aug 9, 2024

We encourage using docker though, that's the simplest way to get started + installs all the deps for you! @rohitt-gupta

It will still work when you change the code - your changes would reflect instantly on both FE and BE.
Only scenario where they wouldn't is if you install new dependencies, but that doesn't apply to this ticket.

@rohitt-gupta
Copy link

Alright, let me try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers react tailwind
Projects
None yet
Development

No branches or pull requests

3 participants