Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] consider using google tests module #128

Closed
2 tasks done
Raffaello opened this issue May 16, 2020 · 3 comments
Closed
2 tasks done

[cmake] consider using google tests module #128

Raffaello opened this issue May 16, 2020 · 3 comments
Assignees
@Raffaello
Labels
configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities
Milestone
Version 0.3.0

Comments

@Raffaello
Copy link
Owner

Raffaello commented May 16, 2020 •
edited
Loading

  • do the test macro first
  • then to replace with gtest macro should be quicker

ref:
https://cmake.org/cmake/help/v3.10/module/GoogleTest.html
@Raffaello Raffaello added configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities labels May 16, 2020
@Raffaello Raffaello added this to the Version 0.3.0 milestone May 16, 2020
@Raffaello Raffaello self-assigned this May 18, 2020
@Raffaello Raffaello mentioned this issue May 19, 2020
Merged
9 tasks
@Raffaello
Copy link
Owner Author

i detect a small issue with snapshot test on linux... not rendering on time the screen, like if it is in asynch mode, adding for eg a delay fix the issue, but because is not ideal, i will disable cmake googletest integration on linux at the moment.

@Raffaello
Copy link
Owner Author

also in MacOS appenging same issue of Linux, so i have extended to "Unix" system. work smoothly only in Windows...

alt image

@Raffaello
Copy link
Owner Author

also in MacOS appenging same issue of Linux, so i have extended to "Unix" system. work smoothly only in Windows...

alt image

Still hold, but it seems related to "rendering performances" rather than OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
configuration cmake or project related code, configuaration refactor improve the code without enhancing in functionalities
Projects
None yet
Milestone
Version 0.3.0
Development

No branches or pull requests
1 participant
@Raffaello