Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TutorialCoachMarkerController next / previous should be async #173

Open
thedalelakes opened this issue Nov 9, 2023 · 0 comments
Open

TutorialCoachMarkerController next / previous should be async #173

thedalelakes opened this issue Nov 9, 2023 · 0 comments

Comments

@thedalelakes
Copy link

thedalelakes commented Nov 9, 2023

TutorialCoachMarkController returns void, despite calling a Future internally.

This means that if a user taps a button, and that button calls controller.next, there is no way to prevent spurious taps to the button calling next multiple times. This causes all sorts of problems if a button (rather than the tap target) is used to navigate, and that button's onPressed call is asynchronous.

Please change controller.next and controller.previous to async functions that wait for the tapHandler to complete before returning.

@thedalelakes thedalelakes changed the title controller.next should be async TutorialCoachMarkerController next / previous should be async Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant