-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation: Simplified Chinese (partial) #353
Conversation
@djyde is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the contribution. One thing though, we need to split multiple namespaces to make the i18n module more maintainable. For example namespace - common is used to store common nouns verbs etc. We don't want to manage all the i18n modules in a single file, as the file will be bloated and difficult to maintain. |
I recommend maintain in one single file. Do you have some open source project example that I can learn how to maintain in seperate namespace? |
Maybe vscode-loc? |
Well. I still don't think it's a good practice. Separating to different files only increases maintainance cost. For example, I just need to translate one single file to get 100% trasnlation for the whole app to another language. And if translations locate on different namespace, you always need to consider which namespace you should use with |
For translation contributors or maintainers, it is indeed better to write all translations in the same file. But imagine if a json has thousands of lines and there are many nested modules, and each developer maintains a different module. In the subsequent development, it is easy to have redundancy and code conflicts. Or, the subsequent module deletion also becomes difficult. Though I do agree with you very much. But we need to break down into at least the following necessary namespaces:
|
If you agree with this, I would move the root resource to namespaces/app |
Also, for the sake of app loading speed, we don't load all the language resources. But by splitting the namespaces, we load the common resource for all languages, but not the others. We only load the language-specific resource when necessary. |
Sure. I will finish the rest of translation after your refactoring |
Signed-off-by: Innei <[email protected]>
@djyde I've refactored it and resolved the code conflicts |
Signed-off-by: Innei <[email protected]>
@Innei Now all the translation is done except the "Wallet" setting panel (I don't have dev api server to test this page). When the Wallet panel is done, I think we can rollout this PR |
Signed-off-by: Innei <[email protected]>
@djyde Can you provide the current cursor ai chat prompt? Thank you very much. |
Open the component you want to translate, then cmd+l: Notice that you need to at(@) the correct locale file |
Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
I've merged it first, I'll continue translating it later |
Have all the content been translated? |
The goal of this PR is to try to translate 100% into Chinese. I speparate different part to track the progress:
Settings
Sidebar
Articles list
Entry content
Discover