Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: muti select action #1062

Merged
merged 22 commits into from
Oct 24, 2024
Merged

feat: muti select action #1062

merged 22 commits into from
Oct 24, 2024

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Oct 22, 2024 •
edited
Loading

Description

ScreenShot.2024-10-24.10.19.43.mp4
ScreenShot.2024-10-24.10.27.32.mp4

Linked Issues

Additional context

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:54am
follow-external-ssr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:54am

@Innei
Copy link
Member

Innei commented Oct 22, 2024

@hyoban try react-selecto ?

@hyoban
Copy link
Member Author

hyoban commented Oct 23, 2024

Will take a look

@github-actions GitHub Actions
Copy link

Linting and formatting issues were automatically fixed. Please review the changes.

@hyoban hyoban marked this pull request as ready for review October 24, 2024 02:21
Innei
Innei approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implement, are there any plans to implement DnD?

@hyoban
Copy link
Member Author

hyoban commented Oct 24, 2024

Of course, maybe complete it in a new PR later

@Innei
Copy link
Member

Innei commented Oct 24, 2024

A UI optimization point: change the selection color to accent color, with a transparency of about 60-70 ?

@Innei
Copy link
Member

Innei commented Oct 24, 2024

Another UX key: need to support Shift Or Ctrl/Cmd multi-selection

Also need to pay attention to the scope of the shortcut keys. #789 @lawvs will probably support this refactor afterward.

@hyoban
Copy link
Member Author

hyoban commented Oct 24, 2024

multi-selection by cmd is already supported

ScreenShot.2024-10-24.16.48.36.mp4

This was referenced Oct 24, 2024
Open
Closed
@hyoban hyoban merged commit 94ab663 into dev Oct 24, 2024
9 checks passed
@hyoban hyoban deleted the feat/muti-select-action branch October 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Innei Innei Innei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoban @Innei