Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Red Hand Files failed with error 0 #3392

Closed
sdenaro opened this issue May 11, 2023 · 6 comments
Closed

The Red Hand Files failed with error 0 #3392

sdenaro opened this issue May 11, 2023 · 6 comments

Comments

@sdenaro
Copy link

sdenaro commented May 11, 2023

Just noticed that this is failing and no one else has reported it.

HttpException: cURL error HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1): 92 (https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://www.theredhandfiles.com in lib/contents.php line 308

index.php(7): RssBridge->main()
lib/RssBridge.php(15): RssBridge->run()
lib/RssBridge.php(92): DisplayAction->execute()
actions/DisplayAction.php(133): TheRedHandFilesBridge->collectData()
bridges/TheRedHandFilesBridge.php(13): getSimpleHTMLDOM()
lib/contents.php(368): getContents()
lib/contents.php(147): _http_request()
lib/contents.php(308)

Query string: action=display&bridge=TheRedHandFilesBridge&format=Atom
Version: dev.2023-03-22 (git.master.6e1048c)
Os: Linux
PHP version: 7.4.33
@dvikan
Copy link
Contributor

dvikan commented May 11, 2023

im unable to reproduce. im on non-docker debian 11, php 7.4.33 and curl 7.74.0 (x86_64-pc-linux-gnu) libcurl/7.74.0

reminds me of #3249

@Mynacol

@Mynacol
Copy link
Contributor

Mynacol commented May 13, 2023

I cannot reproduce this issue either. Tested with php 8.2.6 development server and libcurl 8.0.1.

@sdenaro What libcurl version are you running? Is the issue still present?

@sdenaro
Copy link
Author

sdenaro commented May 14, 2023

PHP 7.4.33 (cli) (built: Feb 22 2023 20:07:47) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.33, Copyright (c), by Zend Technologies

Using:

php -r 'foreach (get_loaded_extensions() as $extension) echo "$extension: " . phpversion($extension) . "\n";'|grep curl

I get

curl: 7.4.33

@Mynacol
Copy link
Contributor

Mynacol commented May 14, 2023

It seems the server is not the culprit here, at least Firefox and curl are using HTTP/2 and working fine in our testing. Maybe the client (curl version) is the culprit here? Ideally you can try with a modern curl version.
A workaround would be to set the HTTP version to 1.1, which we don't wanna do by default.

I also found hints that the culprit might be a HTTP header we send and the web server is not happy about that, leading to that error...

@sdenaro
Copy link
Author

sdenaro commented May 14, 2023

I think I am well overdue to upgrade to php8.x as was as libcurl. I will try that and close the ticket with a note detailing if that worked.

@sdenaro
Copy link
Author

sdenaro commented May 16, 2023

looks like switching to php8.2 plus a current libcurl was enough to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants