Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dark theme #2011

Closed
t0stiman opened this issue Mar 8, 2021 · 4 comments · Fixed by #2029
Closed

Optional dark theme #2011

t0stiman opened this issue Mar 8, 2021 · 4 comments · Fixed by #2029
Labels
Feature-Request Issue is a feature request

Comments

@t0stiman
Copy link
Contributor

t0stiman commented Mar 8, 2021

Is your feature request related to a problem? Please describe.

Some users, including me, prefer dark themes over light themes, because:

  • easier on the eyes, especially at night
  • oled screens use less energy
  • looks cool (subjective of course)

Describe the solution you'd like

I have implemented a dark theme on my fork of rss-bridge. You can test it here and view the source code here.

image

However, many people prefer light themes over dark themes. A possible solution is to add a button on the page somewhere that toggles between light and dark theme.

@t0stiman t0stiman added the Feature-Request Issue is a feature request label Mar 8, 2021
@t0stiman t0stiman changed the title optional dark theme Optional dark theme Mar 8, 2021
@ikajdan
Copy link

ikajdan commented Mar 12, 2021

However, many people prefer light themes over dark themes. A possible solution is to add a button on the page somewhere that toggles between light and dark theme.

You could use @media (prefers-color-scheme: dark) CSS query to apply dark theme based on user's system/browser settings. https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/

@t0stiman
Copy link
Contributor Author

Oh, nice! Im gonna try that.

@ikajdan
Copy link

ikajdan commented Jul 20, 2021

As I know, OLED Screens only consume less energy if the Dark Mode is completely Black (which only looks good on OLED's, in my opinion).

I don't think that's true. It also doesn't really matter in terms of this issue/PR.

@em92 em92 closed this as completed in #2029 Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Request Issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@t0stiman @ikajdan and others