From dd14063236ff00e70c646633e4fceb8d4291a036 Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Fri, 9 Jun 2017 12:08:32 +0100 Subject: [PATCH] Fix napi_create*error to match headers not docs https://github.com/nodejs/node/issues/13555 --- src/exceptions.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/exceptions.js b/src/exceptions.js index d106d3f..e53057c 100644 --- a/src/exceptions.js +++ b/src/exceptions.js @@ -10,25 +10,21 @@ import { lastError, } from './utils'; -function createError(Ctor, msg) { - return new Ctor(UTF8ToString(msg)); -} - function setPendingException(exception) { caughtException(exception); return Status.Ok(); } export function napi_create_error(env, msg, result) { - return setValue(result, createError(Error, msg)); + return setValue(result, new Error(handles[msg])); } export function napi_create_type_error(env, msg, result) { - return setValue(result, createError(TypeError, msg)); + return setValue(result, new TypeError(handles[msg])); } export function napi_create_range_error(env, msg, result) { - return setValue(result, createError(RangeError, msg)); + return setValue(result, new RangeError(handles[msg])); } export function napi_throw(env, error) { @@ -36,15 +32,15 @@ export function napi_throw(env, error) { } export function napi_throw_error(env, msg) { - return setPendingException(createError(Error, msg)); + return setPendingException(new Error(UTF8ToString(msg))); } export function napi_throw_type_error(env, msg) { - return setPendingException(createError(TypeError, msg)); + return setPendingException(new TypeError(UTF8ToString(msg))); } export function napi_throw_range_error(env, msg) { - return setPendingException(createError(RangeError, msg)); + return setPendingException(new RangeError(UTF8ToString(msg))); } export function napi_is_exception_pending(env, result) {