Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] rsx: Fix surface cache references #16843

Open
kd-11 opened this issue Mar 10, 2025 · 3 comments
Open

[Task] rsx: Fix surface cache references #16843

kd-11 opened this issue Mar 10, 2025 · 3 comments
Assignees

Comments

@kd-11
Copy link
Contributor

kd-11 commented Mar 10, 2025

During the investigation into the odd crash observed in Resistance FOM, it became clear that we're holding on to raw pointers from the surface cache. That's just lazy and dangerous, C++ has the tools for safer memory management.

@kd-11 kd-11 self-assigned this Mar 10, 2025
@digant73
Copy link
Contributor

Is that task related to the remaining issue ending with a DEVICE_LOST? As far as I see, PR #16836 fixed the issue #14809 (another bug on surface cache)

@kd-11
Copy link
Contributor Author

kd-11 commented Mar 14, 2025

Is that task related to the remaining issue ending with a DEVICE_LOST

Yes, at least partially.

This will need some planning, I might as well refactor the texture cache while doing this.

@digant73
Copy link
Contributor

good thanks. I will test the PR when it will be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants