From 34b085532e4ad335da020403e57feadcf41025c0 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Fri, 24 Jul 2026 13:27:36 -0500 Subject: [PATCH 1/3] build(rocm-smi): add ROCM_SMI_DISABLE gate to skip build rocm-smi-lib is deprecated in favor of AMD SMI. Setting ROCM_SMI_DISABLE=True (environment or CMake cache variable) short-circuits configure so nothing is built or installed. Composite builds such as TheRock set this to drop the library from the ROCm stack. Signed-off-by: Maisam Arif --- projects/rocm-smi-lib/CHANGELOG.md | 5 +++++ projects/rocm-smi-lib/CMakeLists.txt | 22 +++++++++++++++++++ .../rocm-smi-lib/docs/install/install.rst | 16 ++++++++++++++ 3 files changed, 43 insertions(+) diff --git a/projects/rocm-smi-lib/CHANGELOG.md b/projects/rocm-smi-lib/CHANGELOG.md index 24c5ce31cc68..e241884dcb14 100644 --- a/projects/rocm-smi-lib/CHANGELOG.md +++ b/projects/rocm-smi-lib/CHANGELOG.md @@ -6,6 +6,11 @@ Full documentation for rocm_smi_lib is available at [https://rocm.docs.amd.com/] ## rocm_smi_lib for ROCm 7.2.0 +### Changed + +- **Added `ROCM_SMI_DISABLE` build gate**. + - Setting `ROCM_SMI_DISABLE=True` (environment or CMake cache variable) skips building and installing rocm-smi-lib entirely. Composite builds such as TheRock use this to drop the deprecated library from the ROCm stack. Use [AMD SMI](https://github.com/ROCm/amdsmi) instead. + ### Added - **Added runtime power management detection and device wake support**. diff --git a/projects/rocm-smi-lib/CMakeLists.txt b/projects/rocm-smi-lib/CMakeLists.txt index 8fe43f4d564d..dd330d0d75c7 100644 --- a/projects/rocm-smi-lib/CMakeLists.txt +++ b/projects/rocm-smi-lib/CMakeLists.txt @@ -7,6 +7,28 @@ message("&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&") cmake_minimum_required(VERSION 3.14) project(rocm_smi_lib) +# ROCm SMI is deprecated in favor of AMD SMI. Builds (including TheRock) set +# ROCM_SMI_DISABLE=True to skip building the library entirely. Honor both the +# cache variable and the environment variable of the same name. +if(DEFINED ENV{ROCM_SMI_DISABLE} AND NOT DEFINED ROCM_SMI_DISABLE) + set(ROCM_SMI_DISABLE + "$ENV{ROCM_SMI_DISABLE}" + CACHE BOOL + "Deprecated: skip building rocm-smi-lib" + FORCE + ) +endif() +option(ROCM_SMI_DISABLE "Deprecated: skip building rocm-smi-lib" OFF) + +if(ROCM_SMI_DISABLE) + message( + WARNING + "rocm-smi-lib is deprecated and ROCM_SMI_DISABLE is set; skipping build. " + "Use AMD SMI instead: https://github.com/ROCm/amdsmi" + ) + return() +endif() + set(ROCM_SMI_LIBS_TARGET "rocm_smi_libraries") set(BUILD_SHARED_LIBS ON CACHE BOOL "Build shared library (.so) or not.") diff --git a/projects/rocm-smi-lib/docs/install/install.rst b/projects/rocm-smi-lib/docs/install/install.rst index 027648a50f80..2b3bc4b20d00 100644 --- a/projects/rocm-smi-lib/docs/install/install.rst +++ b/projects/rocm-smi-lib/docs/install/install.rst @@ -61,6 +61,22 @@ After the ROCm SMI library git repository is cloned to a local Linux machine, us The built library will appear in the `build` folder. +Disabling the build +=================== + +Because ROCm SMI is deprecated, its build can be skipped entirely. Set +``ROCM_SMI_DISABLE=True`` as either an environment variable or a CMake cache +variable and the project configures to a no-op, building and installing nothing. +Composite builds such as TheRock use this to drop ROCm SMI from the ROCm stack. + +.. code-block:: shell + + # As an environment variable + ROCM_SMI_DISABLE=True cmake .. + + # Or as a CMake cache variable + cmake .. -DROCM_SMI_DISABLE=True + To build the rpm and deb packages follow the above steps with: .. code-block:: shell From 6e8c07c38c2dcfe017e2f2cf19a4e19665ee258a Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Wed, 29 Jul 2026 02:50:14 -0500 Subject: [PATCH 2/3] docs(rocm-smi): note TheRock exclusion and move changelog to 7.15.0 - Move the ROCM_SMI_DISABLE changelog entry to a new 7.15.0 section - Note in the docs index, README, and install guide that ROCm SMI is no longer included in TheRock builds as of 7.15 and can still be built from source Signed-off-by: Maisam Arif --- projects/rocm-smi-lib/CHANGELOG.md | 6 ++++-- projects/rocm-smi-lib/README.md | 2 ++ projects/rocm-smi-lib/docs/index.rst | 3 +++ projects/rocm-smi-lib/docs/install/install.rst | 3 ++- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/projects/rocm-smi-lib/CHANGELOG.md b/projects/rocm-smi-lib/CHANGELOG.md index e241884dcb14..2e07d57d685d 100644 --- a/projects/rocm-smi-lib/CHANGELOG.md +++ b/projects/rocm-smi-lib/CHANGELOG.md @@ -4,12 +4,14 @@ Full documentation for rocm_smi_lib is available at [https://rocm.docs.amd.com/] ***All information listed below is for reference and subject to change.*** -## rocm_smi_lib for ROCm 7.2.0 +## rocm_smi_lib for ROCm 7.15.0 ### Changed - **Added `ROCM_SMI_DISABLE` build gate**. - - Setting `ROCM_SMI_DISABLE=True` (environment or CMake cache variable) skips building and installing rocm-smi-lib entirely. Composite builds such as TheRock use this to drop the deprecated library from the ROCm stack. Use [AMD SMI](https://github.com/ROCm/amdsmi) instead. + - Setting `ROCM_SMI_DISABLE=True` (environment or CMake cache variable) skips building and installing rocm-smi-lib entirely. rocm-smi-lib is no longer included in TheRock builds; it can still be built from source if desired. Use [AMD SMI](https://github.com/ROCm/amdsmi) instead. + +## rocm_smi_lib for ROCm 7.2.0 ### Added diff --git a/projects/rocm-smi-lib/README.md b/projects/rocm-smi-lib/README.md index 5ef16ebcd009..d95fb445bb45 100644 --- a/projects/rocm-smi-lib/README.md +++ b/projects/rocm-smi-lib/README.md @@ -3,6 +3,8 @@ Starting with ROCm 7.0, only critical bug fixes will be applied to ROCm-SMI. For a seamless experience and continued support, please switch to [AMD-SMI](https://github.com/ROCm/amdsmi). +As of ROCm 7.15, ROCm-SMI is no longer included in TheRock builds. It can still be built from source if desired (see the [installation guide](https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/install/install.html)). + ## Use C++ in ROCm SMI ### Device Indices diff --git a/projects/rocm-smi-lib/docs/index.rst b/projects/rocm-smi-lib/docs/index.rst index 2fa5107fdc8a..39e6e989dda8 100644 --- a/projects/rocm-smi-lib/docs/index.rst +++ b/projects/rocm-smi-lib/docs/index.rst @@ -18,6 +18,9 @@ For more information, refer to ``__. AMD SMI will replace ``rocm_smi_lib`` over time. We recommend that users transition to AMD SMI. + As of ROCm 7.15, ROCm SMI is no longer included in TheRock builds. It can still be built from source if desired + (see the :doc:`installation guide <./install/install>`), but new deployments should use AMD SMI. + For more information, refer to ``__ and the :doc:`AMD SMI documentation `. .. grid:: 2 diff --git a/projects/rocm-smi-lib/docs/install/install.rst b/projects/rocm-smi-lib/docs/install/install.rst index 2b3bc4b20d00..5626fc352139 100644 --- a/projects/rocm-smi-lib/docs/install/install.rst +++ b/projects/rocm-smi-lib/docs/install/install.rst @@ -67,7 +67,8 @@ Disabling the build Because ROCm SMI is deprecated, its build can be skipped entirely. Set ``ROCM_SMI_DISABLE=True`` as either an environment variable or a CMake cache variable and the project configures to a no-op, building and installing nothing. -Composite builds such as TheRock use this to drop ROCm SMI from the ROCm stack. +As of ROCm 7.15, TheRock uses this to exclude ROCm SMI from the ROCm stack; it +can still be built from source if desired. .. code-block:: shell From 5d0fe979426032d211649796765ccac5c0d368b1 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Wed, 29 Jul 2026 03:06:02 -0500 Subject: [PATCH 3/3] docs(rocm-smi): correct ROCm version to 10.0 Signed-off-by: Maisam Arif --- projects/rocm-smi-lib/CHANGELOG.md | 2 +- projects/rocm-smi-lib/README.md | 2 +- projects/rocm-smi-lib/docs/index.rst | 2 +- projects/rocm-smi-lib/docs/install/install.rst | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/rocm-smi-lib/CHANGELOG.md b/projects/rocm-smi-lib/CHANGELOG.md index 2e07d57d685d..3c2127ec4de6 100644 --- a/projects/rocm-smi-lib/CHANGELOG.md +++ b/projects/rocm-smi-lib/CHANGELOG.md @@ -4,7 +4,7 @@ Full documentation for rocm_smi_lib is available at [https://rocm.docs.amd.com/] ***All information listed below is for reference and subject to change.*** -## rocm_smi_lib for ROCm 7.15.0 +## rocm_smi_lib for ROCm 10.0.0 ### Changed diff --git a/projects/rocm-smi-lib/README.md b/projects/rocm-smi-lib/README.md index d95fb445bb45..3e65d0e2ba64 100644 --- a/projects/rocm-smi-lib/README.md +++ b/projects/rocm-smi-lib/README.md @@ -3,7 +3,7 @@ Starting with ROCm 7.0, only critical bug fixes will be applied to ROCm-SMI. For a seamless experience and continued support, please switch to [AMD-SMI](https://github.com/ROCm/amdsmi). -As of ROCm 7.15, ROCm-SMI is no longer included in TheRock builds. It can still be built from source if desired (see the [installation guide](https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/install/install.html)). +As of ROCm 10.0, ROCm-SMI is no longer included in TheRock builds. It can still be built from source if desired (see the [installation guide](https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/install/install.html)). ## Use C++ in ROCm SMI diff --git a/projects/rocm-smi-lib/docs/index.rst b/projects/rocm-smi-lib/docs/index.rst index 39e6e989dda8..8154e4245b21 100644 --- a/projects/rocm-smi-lib/docs/index.rst +++ b/projects/rocm-smi-lib/docs/index.rst @@ -18,7 +18,7 @@ For more information, refer to ``__. AMD SMI will replace ``rocm_smi_lib`` over time. We recommend that users transition to AMD SMI. - As of ROCm 7.15, ROCm SMI is no longer included in TheRock builds. It can still be built from source if desired + As of ROCm 10.0, ROCm SMI is no longer included in TheRock builds. It can still be built from source if desired (see the :doc:`installation guide <./install/install>`), but new deployments should use AMD SMI. For more information, refer to ``__ and the :doc:`AMD SMI documentation `. diff --git a/projects/rocm-smi-lib/docs/install/install.rst b/projects/rocm-smi-lib/docs/install/install.rst index 5626fc352139..37d4dc5e52fa 100644 --- a/projects/rocm-smi-lib/docs/install/install.rst +++ b/projects/rocm-smi-lib/docs/install/install.rst @@ -67,7 +67,7 @@ Disabling the build Because ROCm SMI is deprecated, its build can be skipped entirely. Set ``ROCM_SMI_DISABLE=True`` as either an environment variable or a CMake cache variable and the project configures to a no-op, building and installing nothing. -As of ROCm 7.15, TheRock uses this to exclude ROCm SMI from the ROCm stack; it +As of ROCm 10.0, TheRock uses this to exclude ROCm SMI from the ROCm stack; it can still be built from source if desired. .. code-block:: shell