[hipBLAS] Add Clang guards around usage of openmp config (#1050)#832
Merged
TorreZuk merged 2 commits intoJul 29, 2025
Conversation
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. [ROCm/hipBLAS commit: 4639103]
estewart08
requested review from
NaveenElumalaiAMD,
TorreZuk,
amcamd,
bragadeesh,
daineAMD,
mahmoodw and
rkamd
as code owners
TorreZuk
changed the title
TorreZuk
reviewed
Jul 24, 2025
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
LGTM but won't approve until we know dockers are fixed. May happen after this branch is no longer used but can still merge once safe.
aferoz21
pushed a commit
that referenced
this pull request
Jul 24, 2025
* generic extract routine Co-authored-by: Nico Trost <nico.trost@amd.com> [ROCm/rocSPARSEcommit: 056564b]
TorreZuk
approved these changes
Jul 28, 2025
Collaborator
|
Hi, |
…as-openmp-clang-guard-release-staging-7-0
Contributor
|
Should this be to release staging or release? |
Contributor
Yes this is for an edge case build and test usage so correctly targets stale branch release-staging |
amd-jnovotny
approved these changes
Jul 29, 2025
TorreZuk
merged commit 121d2e7
into
release-staging/rocm-rel-7.0
11 of 14 checks passed
TorreZuk
deleted the
users/estewart/hipblas-openmp-clang-guard-release-staging-7-0
branch
assistant-librarian Bot
pushed a commit
to ROCm/hipBLAS
that referenced
this pull request
Jul 29, 2025
[hipBLAS] Add Clang guards around usage of openmp config (#1050) (#832) This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. [ROCm/hipBLAS commit: 4639103] This patch is dependent on the Ubuntu 24.04 docker file being updated to use AOCL 4.2 instead of 4.0. Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Sep 18, 2025
* rtest emulation flag and smoke filter * add regression and extended filters [ROCm/rocSOLVER commit: ef87841]
mgates3
pushed a commit
to mgates3/rocm-libraries
that referenced
this pull request
Mar 6, 2026
* rtest emulation flag and smoke filter * add regression and extended filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a gcc issue where clang headers are being brought in by the openmp-config.
Additional cleanup:
Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang.
[ROCm/hipBLAS commit: 4639103]
This patch is dependent on the Ubuntu 24.04 docker file being updated to use AOCL 4.2 instead of 4.0.