[rocRAND] implement additional unit tests for better code coverage#79
Closed
assistant-librarian[bot] wants to merge 44 commits into
Closed
[rocRAND] implement additional unit tests for better code coverage#79assistant-librarian[bot] wants to merge 44 commits into
assistant-librarian[bot] wants to merge 44 commits into
Conversation
* Bump cryptography from 43.0.1 to 44.0.1 in /docs/sphinx (#611) Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.1 to 44.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.1...44.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * added test_discrete_distribution file * finished discrete_alias tests * temp commit * merged in cmake fix * started updating functions * added cdf tests (not done need to modify) * reformated tests * finalized discrete_distribution tests * updated changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
assistant-librarian
Bot
requested review from
RobsonRLemos,
lawruble13 and
umfranzw
as code owners
Contributor
|
Closing this PR and opening #89 so that I can add additional unit tests from my fork |
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* add tensor value * fix format * review comments and add more tests * format
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* add tensor value * fix format * review comments and add more tests * format [ROCm/hipDNN commit: 734f34f]
evetsso
pushed a commit
to evetsso/rocm-libraries
that referenced
this pull request
Dec 31, 2025
Merge latest develop into gfx1250 branch.
yraparti
added a commit
that referenced
this pull request
Mar 26, 2026
Fix a bug in the smart-build --ctest-only filter that was incorrectly excluding tests with numbers less than 100. The issue was caused by CTest formatting test numbers with variable spacing based on the number of digits: - Test #1: name (3 spaces for tests 1-9) - Test #79: name (2 spaces for tests 10-99) - Test #100: name (1 space for tests 100+) The previous code used `line.strip().startswith("Test #")` which only matched tests with a single space (i.e., test numbers >= 100). This caused tests like ck_tile_unit_sequence (Test #79) to be excluded from smart-build test selection, resulting in CTest failures when the binary wasn't built. Solution: Replace string matching with a regex pattern that handles all spacing variations: r'^\s*Test\s+#\d+:\s*(.+)$' Impact: - Before: 48 tests selected (only tests #100+) - After: 146 tests selected (all CTest-registered tests) Tested with test numbers from 1 to 12345. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
illsilin
added a commit
that referenced
this pull request
Mar 27, 2026
) ## Motivation Fix a bug in the smart-build --ctest-only filter that was incorrectly excluding tests with numbers less than 100. ## Technical Details The issue was caused by CTest formatting test numbers with variable spacing based on the number of digits: - "Test `#1`: name (3 spaces for tests 1-9)" - "Test `#79`: name (2 spaces for tests 10-99)" - "Test `#100`: name (1 space for tests 100+)" The previous code used `line.strip().startswith("Test #")` which only matched tests with a single space (i.e., test numbers >= 100). This caused tests like ck_tile_unit_sequence (Test #79) to be excluded from smart-build test selection, resulting in CTest failures when the binary wasn't built. Solution: Replace string matching with a regex pattern that handles all spacing variations: r'^\s*Test\s+#\d+:\s*(.+)$' ## Test Plan Tested with test numbers from 1 to 12345. ## Test Result - Before: 48 tests selected (only tests #100+) - After: 146 tests selected (all CTest-registered tests) ## Submission Checklist - [x ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
bethune-bryant
pushed a commit
that referenced
this pull request
Apr 3, 2026
Will add back after debugging. Co-authored-by: menghung_amdeng <menghung@amd.com>
jichangjichang
pushed a commit
that referenced
this pull request
Apr 8, 2026
Will add back after debugging. Co-authored-by: menghung_amdeng <menghung@amd.com>
vidyasagar-amd
pushed a commit
that referenced
this pull request
Apr 9, 2026
) ## Motivation Fix a bug in the smart-build --ctest-only filter that was incorrectly excluding tests with numbers less than 100. ## Technical Details The issue was caused by CTest formatting test numbers with variable spacing based on the number of digits: - "Test `#1`: name (3 spaces for tests 1-9)" - "Test `#79`: name (2 spaces for tests 10-99)" - "Test `#100`: name (1 space for tests 100+)" The previous code used `line.strip().startswith("Test #")` which only matched tests with a single space (i.e., test numbers >= 100). This caused tests like ck_tile_unit_sequence (Test #79) to be excluded from smart-build test selection, resulting in CTest failures when the binary wasn't built. Solution: Replace string matching with a regex pattern that handles all spacing variations: r'^\s*Test\s+#\d+:\s*(.+)$' ## Test Plan Tested with test numbers from 1 to 12345. ## Test Result - Before: 48 tests selected (only tests #100+) - After: 146 tests selected (all CTest-registered tests) ## Submission Checklist - [x ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
jichangjichang
pushed a commit
that referenced
this pull request
Apr 13, 2026
Will add back after debugging. Co-authored-by: menghung_amdeng <menghung@amd.com>
jichangjichang
pushed a commit
that referenced
this pull request
Apr 13, 2026
Will add back after debugging. Co-authored-by: menghung_amdeng <menghung@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔁 Imported from ROCm/rocRAND#619
🧑💻 Originally authored by @NguyenNhuDi