[hipDNN] Migrate golden reference system into integration tests#7480
Open
bghimireamd wants to merge 6 commits into
Open
[hipDNN] Migrate golden reference system into integration tests#7480bghimireamd wants to merge 6 commits into
bghimireamd wants to merge 6 commits into
Conversation
…on tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bghimireamd
changed the title
Complete the relocation by removing the original golden reference files from test_sdk now that they live in integration-tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (69.24%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7480 +/- ##
===========================================
- Coverage 60.33% 60.31% -0.02%
===========================================
Files 1179 1181 +2
Lines 215587 216054 +467
Branches 22951 23011 +60
===========================================
+ Hits 130071 130311 +240
- Misses 76997 77206 +209
- Partials 8519 8537 +18
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
…integration-tests Move hipdnn_reference_data/ and reference_data_scripts/ from projects/hipdnn/ to dnn-providers/integration-tests/ so the golden reference data lives alongside the tests that consume it. Update CMake paths in both integration-tests and hipdnn CMakeLists to reflect the new location, with an if(EXISTS) guard in hipdnn for standalone builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… builds The install() for hipdnn_reference_data was unconditional but the file(COPY) that populates the build tree is guarded by if(EXISTS). In standalone builds (e.g. TheRock CI) where the reference data source does not exist, the copy is skipped but install fails. Wrap install() in if(EXISTS) so it is skipped when the data was not copied into the build tree. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rence data The reference data (.json and .bin files) moved from projects/hipdnn/hipdnn_reference_data/ to dnn-providers/integration-tests/hipdnn_reference_data/ but the pre-commit exclusion pattern still pointed to the old path, causing the end-of-file-fixer hook to fail in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bghimireamd
force-pushed
the
users/bghimire/ALMIOPEN-1944/migrate-golden-ref-to-integration-tests
branch
from
ce27f37 to
eb47cac
Compare
… data Mark *.bin files as binary to prevent line-ending corruption from git autocrlf or merge tools. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
adickin-amd
reviewed
May 21, 2026
| install(DIRECTORY "${CMAKE_BINARY_DIR}/lib/hipdnn_reference_data" | ||
| DESTINATION ${HIPDNN_TEST_REFERENCE_INSTALL_DIR} | ||
| ) | ||
| set(_hipdnn_ref_data_src |
Contributor
There was a problem hiding this comment.
does this belong here anymore? should it just be in the integration-tests project?
adickin-amd
reviewed
May 21, 2026
|
|
||
| # Copy golden reference data into the build tree so tests can find it at | ||
| # <exe_dir>/../lib/hipdnn_reference_data/ | ||
| file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/hipdnn_reference_data/" |
Contributor
There was a problem hiding this comment.
should probably mention this only copies at configure time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is Phase 1 of the golden reference migration — relocating existing files with minimal changes. Future phases will focus on validating reference data bundles, strengthening the verification framework, and then expanding coverage to additional operations.
Summary
test_sdkintointegration-testsGoldenReferenceCpu.hppharness adapted for the integration-tests namespacetest_sdkto complete the relocationhipdnn_reference_data/andreference_data_scripts/fromprojects/hipdnn/tointegration-tests/Test plan
hipdnn_integration_testsbuilds successfullyhipdnn_test_sdk_testsbuilds successfully (no regressions)cmake --installsucceeds (mono-repo and standalone)--gtest_list_tests🤖 Generated with Claude Code