[rocBLAS] adds axpy replacement reference code when using windows OpenBLAS#7184
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (69.24%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7184 +/- ##
========================================
Coverage 62.78% 62.78%
========================================
Files 972 972
Lines 185366 185364 -2
Branches 21999 21997 -2
========================================
Hits 116376 116376
+ Misses 61008 61006 -2
Partials 7982 7982
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
evedovelli
approved these changes
May 8, 2026
TorreZuk
force-pushed
the
users/torrezuk/rocm-23872-add-axpy-ref
branch
from
d3f38d9 to
755ad37
Compare
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
May 13, 2026
[rocBLAS] adds axpy replacement reference code when using windows OpenBLAS (#7184) This pull request introduces a Windows-specific implementation of the `ref_axpy` function to address compatibility issues when using OpenBLAS on Windows. The main changes involve conditionally compiling a new template implementation for `ref_axpy` and updating the header to ensure the correct version is used based on the platform and build configuration. Platform-specific implementation for Windows: * Added a custom template implementation of `ref_axpy` for Windows platforms when BLIS CBLAS is not enabled, including specializations for `float`, `double`, `rocblas_float_complex`, `rocblas_double_complex`, and a custom implementation for `rocblas_bfloat16` that performs computation in float precision. (`projects/rocblas/clients/common/cblas_interface.cpp`) Header updates for conditional compilation: * Updated the declaration and inline implementation of `ref_axpy` in `cblas_interface.hpp` to use the new Windows-specific override only when appropriate, ensuring the standard implementation is excluded on Windows/OpenBLAS builds without BLIS CBLAS. (`projects/rocblas/clients/include/cblas_interface.hpp`) ROCM-23872
aledudek
pushed a commit
that referenced
this pull request
May 20, 2026
…nBLAS (#7184) This pull request introduces a Windows-specific implementation of the `ref_axpy` function to address compatibility issues when using OpenBLAS on Windows. The main changes involve conditionally compiling a new template implementation for `ref_axpy` and updating the header to ensure the correct version is used based on the platform and build configuration. Platform-specific implementation for Windows: * Added a custom template implementation of `ref_axpy` for Windows platforms when BLIS CBLAS is not enabled, including specializations for `float`, `double`, `rocblas_float_complex`, `rocblas_double_complex`, and a custom implementation for `rocblas_bfloat16` that performs computation in float precision. (`projects/rocblas/clients/common/cblas_interface.cpp`) Header updates for conditional compilation: * Updated the declaration and inline implementation of `ref_axpy` in `cblas_interface.hpp` to use the new Windows-specific override only when appropriate, ensuring the standard implementation is excluded on Windows/OpenBLAS builds without BLIS CBLAS. (`projects/rocblas/clients/include/cblas_interface.hpp`) ROCM-23872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a Windows-specific implementation of the
ref_axpyfunction to address compatibility issues when using OpenBLAS on Windows. The main changes involve conditionally compiling a new template implementation forref_axpyand updating the header to ensure the correct version is used based on the platform and build configuration.Platform-specific implementation for Windows:
ref_axpyfor Windows platforms when BLIS CBLAS is not enabled, including specializations forfloat,double,rocblas_float_complex,rocblas_double_complex, and a custom implementation forrocblas_bfloat16that performs computation in float precision. (projects/rocblas/clients/common/cblas_interface.cpp)Header updates for conditional compilation:
ref_axpyincblas_interface.hppto use the new Windows-specific override only when appropriate, ensuring the standard implementation is excluded on Windows/OpenBLAS builds without BLIS CBLAS. (projects/rocblas/clients/include/cblas_interface.hpp)ROCM-23872