-
Notifications
You must be signed in to change notification settings - Fork 294
[hipDNN] Heuristic Policy Framework + Default Plugins (RFC 0007 - Part 2/3) #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cderb
merged 136 commits into
develop
from
users/cderb/rfc0007/pr2-heuristic-framework-plugins
May 20, 2026
Merged
Changes from all commits
Commits
Show all changes
136 commits
Select commit
Hold shift + click to select a range
37111be
[hipDNN] Plugin SDK + Device Properties Infrastructure (RFC 0007 - Pa…
cderb 1e54ffb
Fix RFC references to include RFC 0007 prefix
cderb 1e19a4d
Add missing HipdnnException.hpp include to TestDeviceProperties
cderb 683886a
RFC 0007: Engine Selection Heuristics Framework (Backend + Plugins)
cderb 18d094a
Add RFC 0007 documentation
cderb 909ccfe
Merge PR1: Add RFC 0007 documentation
cderb f254105
Fix RFC 0007 labels and add missing test files to CMakeLists
cderb 2af1ffe
Fix compilation errors
cderb 4a4abad
compilation fixes
cderb 2a72673
Fix RFC 0007 heuristic plugin ABI compliance and test infrastructure
cderb c4dc2d3
correct engine name in tests
cderb 49f6188
Apply code quality and ABI fixes to PR1 Plugin SDK infrastructure
cderb 5856d6e
Add unit tests for RFC 0007 Part 1 Plugin SDK infrastructure
cderb 2da1d23
formatting corrections
cderb 853b064
Fix pre-commit hook failures
cderb 05af187
fix generated files
cderb 78bd506
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 5ff2578
add more coverage tests
cderb f1c3f8e
format on test files
cderb 98b1892
Add comprehensive HeuristicPlugin test coverage
cderb e2a17a6
Fixed race condition in heuristic plugin initialization.
cderb 5947d05
format
cderb 35c2155
reorganize heuristic plugin tests, reduce test files, add to plugin m…
cderb aeb7d54
remove special unicode characters
cderb 359c8aa
Require policy names and compute policy IDs from names
cderb 59a692c
Add architectureName to device properties for LLVM architecture support
cderb 6a24652
revert EngineOrdering changes, will re-investigate need in part 2
cderb c40cf35
format
cderb b8c2eda
format
cderb ad1ec05
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb e98e1a6
fix directory resolution for heuristic plugin ci test
cderb f14e817
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb 0be745e
test fixes
cderb 08429e3
nolints
cderb 4187f50
format
cderb 8d72819
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb c42198f
share sortEngineIds to plugins
cderb 0dde900
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 1b97bb9
addressing reviews
cderb cc61d02
use weak ptr to track heuristic plugin manager resources
cderb 6380677
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb c3d4846
format
cderb 59e6ae6
format
cderb bb298a7
remove heuristicLoggingCallback and use backendLoggingCallback directly
cderb 94b9680
update patch version
cderb d9763c2
makelist corrections
cderb ee29b1c
corrections for MockHeuristicPlugin, add virtual to HeuristicPlugin m…
cderb 348e797
review comments
cderb 7e837d2
add PluginResourceManagerBase
cderb 9145dbb
format
cderb 86f19ad
windows test fix
cderb b21936c
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb 45d57b3
refactor HeuristicsPluginApi to extend PluginApi
cderb 9a0dd37
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb e96b5b8
update plugins to match updates from part 1
cderb f14da60
windows friendly test paths
cderb 72a83c0
fix test
cderb 3eb163b
Fix test for windows path names
jdcampbe 2917710
Fix SharedLibrary move losing _libraryPath after std::move
jdcampbe 8f674e6
format
cderb 4a1bb70
tidy fix
cderb c506129
Merge branch 'users/cderb/rfc0007/pr1-plugin-sdk-infrastructure' into…
cderb 0b83769
Apply clang-format to PR2 files
claude 9507946
tidy
cderb 2f6830c
Fix heuristic plugin discovery for cross-platform CI
cderb 742c1c6
Clean up HeuristicsPluginApi documentation and naming
cderb b7e46a2
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 1bd1f2f
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 13aed83
remove so suffix for windows build
cderb e63202e
add plugin dependency for coverage test
cderb 47e691b
copy plugins to build for test
cderb 63de4f6
add test build dependencies
cderb 9e73627
RFC 0007: Improve test coverage and optimize test suite
cderb 5825a60
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 1058517
Apply clang-format to PR2 test files
cderb 7614d52
Fix all clang-tidy errors from CI (PR2)
cderb d80fe5e
format
cderb 839ab18
fix paths for windows
cderb 3963fb6
format
cderb 200d921
Fix Windows test failures by unloading plugins before cleanup
cderb 6a9d0a2
addressing reviews
cderb 93ac99c
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 49937a1
Port engine plugin CMake patterns to heuristic plugins
cderb 724eb83
Hold shared_ptr to resource manager + policy ID in SelectionHeuristic
cderb d055b8b
Switch HIPDNN_ATTR_ENGINEHEUR_POLICY_ORDER_EXT to int64 policy IDs
cderb 7640e1f
Address heuristic descriptor and SelectionHeuristic review feedback
cderb 073158b
Move EngineOverrideConfig from frontend into ConfigPlugin
cderb 85f3da2
Centralize test plugin target names in cmake/TestPluginNames.cmake
cderb 529b371
Refine heuristic plugin tests: dedup, regroup, rename per CLAUDE.md
cderb 1c6cd31
Drop fallback heuristic plugin search paths
cderb a6aec58
Cover policy order env var, descriptor precedence, and empty list
cderb d6f996d
Refactor heuristic plugins to OBJECT/STATIC/SHARED target pattern
cderb adfae53
Move heuristic plugin tests into per-plugin tests/ directories
cderb af332d4
Share BAD_PARAM checks via HeuristicValidation.hpp; drop loadFromEnv …
cderb 7211d1f
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 71f998e
Add hipdnnSetHeuristicPluginPaths_ext and isolate backend tests from …
cderb 883f9a9
Isolate frontend tests from real heuristic plugins
cderb aa45628
Drop unused Config/StaticOrdering deps from hipdnn_backend_tests
cderb f73ef78
Reset derived plugin-manager state on ABSOLUTE reload
cderb 0525166
Drop RFC 0007 references from source comments
cderb 3f5281d
update comments for hipdnnGetHeuristicPolicyInfo_ext
cderb d127c92
Apply RAII to heuristic test files
cderb c1abb49
Support 1:N heuristic plugin-to-policy ABI
cderb 1c84598
Cover HeuristicPlugin load-time validation paths
cderb 544e264
clang-format
cderb 38f77f5
clang-tidy: use s_ prefix for function-static IDs
cderb b9b7405
windows environment var fix
cderb d4af347
Migrate default heuristic plugin to backend built-ins
cderb 2372de6
Move HIPDNN_DEFAULT_ENGINE handling to backend resolver
cderb 74c95b8
clang-format
cderb 5eb0b9e
Replace HIPDNN_DEFAULT_ENGINE with HIPDNN_FALLBACK_ENGINE_ORDERING
cderb 6919163
Move Graph.preferred_engine_id handling back to the frontend
cderb 03a5caa
Convert engine override resolver into Config built-in policy
cderb 324a8dc
Rename heuristic-related env vars to HIPDNN_HEUR_* prefix
cderb 1b803a0
Add coverage tests for Config and StaticOrdering built-in policies
cderb 7fd084c
clang-format
cderb 3a480c8
update heuristic policy order setting
cderb 5a626c9
format
cderb 985bbd6
Bind real stream to handle in heuristic descriptor tests
cderb 7018b9a
Skip heuristic plugin tests on no-GPU CI runners
cderb ea26800
Make setDeviceProperties failure fail-soft per heuristic plugin
cderb c54cdbd
Expose pluginName from hipdnnGetHeuristicPolicyInfo_ext
cderb 4c62be1
comment correction
cderb d112871
Document heuristic policy env vars in Environment.md
cderb 40426ba
reject stride mismatch for tensor
cderb 4f92332
Assert PreferNonExistentEngineId succeeds in engine filtering test
cderb eb6ad3a
Revert "Assert PreferNonExistentEngineId succeeds in engine filtering…
cderb e86f245
Make PreferNonExistentEngineId assertion deterministic
cderb 9072b87
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 7b7a6ba
Pin heuristic workflow tests to the test good plugin
cderb f6b7e26
Pin remaining heuristic plugin tests to a known policy ID
cderb 593e12f
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 113d02b
RAII leak fixes, heuristic plugin hardening, and shared logging
cderb 41c61ae
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb 00dfbbf
clang-format review-cycle changes
cderb 8ce4fc2
Merge remote-tracking branch 'origin/develop' into users/cderb/rfc000…
cderb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BrianHarrisonAMD marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.