Skip to content

[TensileLite] Fix MX FP4 scale data initialization & argument scoping#4917

Merged
pdhirajkumarprasad merged 2 commits into
gfx950_mx_rebasefrom
users/aramalin/mxfp4_test_fix
Feb 26, 2026
Merged

[TensileLite] Fix MX FP4 scale data initialization & argument scoping#4917
pdhirajkumarprasad merged 2 commits into
gfx950_mx_rebasefrom
users/aramalin/mxfp4_test_fix

Conversation

@archana-ramalingam
Copy link
Copy Markdown
Contributor

@archana-ramalingam archana-ramalingam commented Feb 26, 2026

Motivation

Fix MXFP4 scale data initialization and kernel argument scoping

Technical Details

  • DataInitialization.cpp: Extend initializeCPUInputs skip guard to include MXSA/MXSB — the general tensor loop was overwriting correlated scale data from initializeMXDataForFP4 with independent random UE8M0 values, causing intermittent single-element validation failures from sub-ULP hardware/software dequantization differences UE8M0float32
  • ContractionSolution.cpp: Gate scaleA/scaleB argument appending on useScaleAB only — MX problems without UseScaleAB were incorrectly passing scale pointers to kernels that don't expect them
  • Signature.py: Fix indentation of userArgumentsInfo size increments for scaleA/B/C/D, bias, and E tensor — sizes were unconditionally accumulated outside their feature if blocks, producing incorrect kernel argument layouts

Test Plan

TBD

Test Result

TBD

Submission Checklist

@archana-ramalingam archana-ramalingam changed the title Fix failing tests [TensileLite] Fix MX FP4 scale data overwrite in initializeCPUInputs Feb 26, 2026
@pdhirajkumarprasad pdhirajkumarprasad merged commit fd621eb into gfx950_mx_rebase Feb 26, 2026
15 of 23 checks passed
@pdhirajkumarprasad pdhirajkumarprasad deleted the users/aramalin/mxfp4_test_fix branch February 26, 2026 16:35
@archana-ramalingam archana-ramalingam changed the title [TensileLite] Fix MX FP4 scale data overwrite in initializeCPUInputs [TensileLite] Fix MX FP4 scale data initialization Feb 27, 2026
@archana-ramalingam archana-ramalingam changed the title [TensileLite] Fix MX FP4 scale data initialization [TensileLite] Fix MX FP4 scale data initialization & argument scoping Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants