From 2528d7d0eb49ea93f7e56c46501bf3acbdc77096 Mon Sep 17 00:00:00 2001 From: hsivasun_amdeng Date: Tue, 25 Nov 2025 04:46:51 +0000 Subject: [PATCH 1/5] updating workflow trigger for release branch and using head of rock rel 7.10 --- .github/workflows/therock-ci-linux.yml | 2 +- .github/workflows/therock-ci-windows.yml | 2 +- .github/workflows/therock-ci.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index dcbc7f68c85..a6c37f8ec54 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -47,7 +47,7 @@ jobs: with: repository: "ROCm/TheRock" path: TheRock - ref: d24cccc1820fa5469b88c0f14e36a14349d38cac # 2025-11-12 commit + ref: "release/therock-7.10" # 2025-11-24 pointing to release/therock-7.10 head commit - name: Install python deps run: | diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index 75f1ac81f9f..eab4da47973 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -55,7 +55,7 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: d24cccc1820fa5469b88c0f14e36a14349d38cac # 2025-11-12 commit + ref: "release/therock-7.10" # 2025-11-24 pointing to release/therock-7.10 head commit - name: Set up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 diff --git a/.github/workflows/therock-ci.yml b/.github/workflows/therock-ci.yml index 4a29758c58a..6041109706b 100644 --- a/.github/workflows/therock-ci.yml +++ b/.github/workflows/therock-ci.yml @@ -3,7 +3,7 @@ name: TheRock CI on: push: branches: - - develop + - release/therock-7.10 pull_request: types: - opened From f8d2318f527ee05542f314d244804ab2f91266ca Mon Sep 17 00:00:00 2001 From: hsivasun_amdeng Date: Wed, 26 Nov 2025 22:35:20 +0000 Subject: [PATCH 2/5] pinning theROCK to commit hash and updating trigger condition --- .github/workflows/therock-ci-linux.yml | 2 +- .github/workflows/therock-ci-windows.yml | 2 +- .github/workflows/therock-ci.yml | 3 ++- .github/workflows/therock-test-component.yml | 2 +- .github/workflows/therock-test-packages.yml | 4 ++-- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index a6c37f8ec54..02c072246d9 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -47,7 +47,7 @@ jobs: with: repository: "ROCm/TheRock" path: TheRock - ref: "release/therock-7.10" # 2025-11-24 pointing to release/therock-7.10 head commit + ref: "e238c0269a9e54b275ef34ffb43c6c52a0cddc83" # 2025-11-26 commit on release/therock-7.10 branch - name: Install python deps run: | diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index eab4da47973..796edd2f5a8 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -55,7 +55,7 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: "release/therock-7.10" # 2025-11-24 pointing to release/therock-7.10 head commit + ref: "e238c0269a9e54b275ef34ffb43c6c52a0cddc83" # 2025-11-26 commit on release/therock-7.10 branch - name: Set up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 diff --git a/.github/workflows/therock-ci.yml b/.github/workflows/therock-ci.yml index 6041109706b..734fa11125a 100644 --- a/.github/workflows/therock-ci.yml +++ b/.github/workflows/therock-ci.yml @@ -3,7 +3,8 @@ name: TheRock CI on: push: branches: - - release/therock-7.10 + - develop + - release/therock-* pull_request: types: - opened diff --git a/.github/workflows/therock-test-component.yml b/.github/workflows/therock-test-component.yml index 9027f9e6e55..f06043a86e8 100644 --- a/.github/workflows/therock-test-component.yml +++ b/.github/workflows/therock-test-component.yml @@ -64,7 +64,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 with: repository: "ROCm/TheRock" - ref: d24cccc1820fa5469b88c0f14e36a14349d38cac # 2025-11-12 commit + ref: e238c0269a9e54b275ef34ffb43c6c52a0cddc83 # 2025-11-26 commit on release/therock-7.10 branch - name: Run setup test environment workflow uses: './.github/actions/setup_test_environment' diff --git a/.github/workflows/therock-test-packages.yml b/.github/workflows/therock-test-packages.yml index be1dd9ac4d5..f6f22cce2a8 100644 --- a/.github/workflows/therock-test-packages.yml +++ b/.github/workflows/therock-test-packages.yml @@ -31,7 +31,7 @@ jobs: sparse-checkout: build_tools path: "prejob" repository: "ROCm/TheRock" - ref: d24cccc1820fa5469b88c0f14e36a14349d38cac # 2025-11-12 commit + ref: e238c0269a9e54b275ef34ffb43c6c52a0cddc83 # 2025-11-26 commit on release/therock-7.10 branch # Checkout failure is possible on Windows, as it's the first job on a GPU test runner. # Post-job cleanup isn't necessary since no executables are launched in this job. @@ -44,7 +44,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 with: repository: "ROCm/TheRock" - ref: d24cccc1820fa5469b88c0f14e36a14349d38cac # 2025-11-12 commit + ref: e238c0269a9e54b275ef34ffb43c6c52a0cddc83 # 2025-11-26 commit on release/therock-7.10 branch - name: Setting up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 From 210318b512df74c6a889b6400a74a6da7bfd14f0 Mon Sep 17 00:00:00 2001 From: RahulC <168588218+rahulc-gh@users.noreply.github.com> Date: Wed, 26 Nov 2025 15:15:15 -0800 Subject: [PATCH 3/5] Update therock-ci.yml - push request build trigger not needed --- .github/workflows/therock-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/therock-ci.yml b/.github/workflows/therock-ci.yml index 734fa11125a..4a29758c58a 100644 --- a/.github/workflows/therock-ci.yml +++ b/.github/workflows/therock-ci.yml @@ -4,7 +4,6 @@ on: push: branches: - develop - - release/therock-* pull_request: types: - opened From d18525c60efcf4a81c5021b43538fae145923246 Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Thu, 27 Nov 2025 16:14:29 +0000 Subject: [PATCH 4/5] add installing python packages for external dependencies --- .github/workflows/therock-ci-linux.yml | 4 ++++ .github/workflows/therock-ci-windows.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index 02c072246d9..6c82deb1caa 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -53,6 +53,10 @@ jobs: run: | pip install -r TheRock/requirements.txt + - name: Install external python deps + run: | + pip install -r TheRock/requirements-external.txt + # safe.directory must be set before Runner health status - name: Adjust git config run: | diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index 796edd2f5a8..ca783a2598e 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -66,6 +66,10 @@ jobs: run: | pip install -r TheRock/requirements.txt + - name: Install external python deps + run: | + pip install -r TheRock/requirements-external.txt + - name: Patch rocm-libraries run: | # Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo From 337191dc28a8d24a764a62de29316f94c6330025 Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Thu, 27 Nov 2025 16:33:19 +0000 Subject: [PATCH 5/5] move to correct position --- .github/workflows/therock-ci-linux.yml | 8 ++++---- .github/workflows/therock-ci-windows.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index 6c82deb1caa..43ed5c90b9a 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -53,10 +53,6 @@ jobs: run: | pip install -r TheRock/requirements.txt - - name: Install external python deps - run: | - pip install -r TheRock/requirements-external.txt - # safe.directory must be set before Runner health status - name: Adjust git config run: | @@ -94,6 +90,10 @@ jobs: # rm ./TheRock/patches/amd-mainline/rocm-libraries/*.patch git -c user.name="therockbot" -c "user.email=therockbot@amd.com" am --whitespace=nowarn ./TheRock/patches/amd-mainline/rocm-libraries/*.patch + - name: Install external python deps + run: | + pip install -r TheRock/requirements-external.txt + - name: Configure Projects env: amdgpu_families: ${{ env.AMDGPU_FAMILIES }} diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index ca783a2598e..9cecc97d59f 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -66,10 +66,6 @@ jobs: run: | pip install -r TheRock/requirements.txt - - name: Install external python deps - run: | - pip install -r TheRock/requirements-external.txt - - name: Patch rocm-libraries run: | # Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo @@ -109,6 +105,10 @@ jobs: git config --global core.longpaths true python ./TheRock/build_tools/fetch_sources.py --jobs 12 --no-include-rocm-libraries --no-include-ml-frameworks + - name: Install external python deps + run: | + pip install -r TheRock/requirements-external.txt + - name: Configure Projects env: amdgpu_families: ${{ env.AMDGPU_FAMILIES }}