[hipDNN] [ALMIOPEN-224] Windows Build #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s except miopen_legacy_plugin_tests
…y_plugin private lib
…b.com:ROCm/rocm-libraries into users/mousdahl-amd/almiopen-224_windows_build
Use the config files provided by upstream instead of a custom finder.
This code is built on shaky assumptions that don't hold inside TheRock. We'll need a better solution that works across projects.
This reverts commit 68a380c. This breaks building rocBLAS on Windows.
…/almiopen-224_windows_build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2527 +/- ##
============================================
+ Coverage 67.19% 90.64% +23.45%
============================================
Files 362 3 -359
Lines 50789 21043 -29746
Branches 5741 469 -5272
============================================
- Hits 34126 19074 -15052
+ Misses 13057 1871 -11186
+ Partials 3606 98 -3508
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ScottTodd
reviewed
Nov 7, 2025
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Thanks! Looks good. Just a few comments and infra/build issues to fix
projects/hipdnn/plugins/miopen_legacy_plugin/MiopenLegacyPlugin.cpp
Outdated
Show resolved
Hide resolved
projects/hipdnn/sdk/include/hipdnn_sdk/utilities/StaticCast.hpp
Outdated
Show resolved
Hide resolved
BrianHarrisonAMD
approved these changes
Nov 7, 2025
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
Looks good to me.
Some minor comments, and questions, but ill leave that up to you!
mousdahl-amd
deleted the
users/mousdahl-amd/almiopen-224_windows_build
branch
rithwik-amd
pushed a commit
that referenced
this pull request
Nov 7, 2025
## Motivation Add the ability to build / test hipDNN in Windows ## Technical Details - A number of small changes to compile on Windows - A number of small changes to compile under theRock - Adjusted test plugin paths on Windows since dlls are considered runtimes in CMake - Linking the miopen_legacy_plugin_test.exe statically to miopen_legacy_plugin private lib ## Test Plan - [x] Run all unit tests - [x] Run all integration tests - [x] No ASAN on Windows yet ## Test Result - [x] All tests passing ## Submission Checklist - [x] clang-tidy - [x] clang-format --------- Co-authored-by: Marius Brehler <[email protected]> Co-authored-by: Scott Todd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add the ability to build / test hipDNN in Windows
Technical Details
Test Plan
Test Result
Submission Checklist