Tensile: add gfx1036 to cmake and add missing gfx1034-1036 to AsmCaps & Common.#2297
Tensile: add gfx1036 to cmake and add missing gfx1034-1036 to AsmCaps & Common.#2297jerenkrantz wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (67.07%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #2297 +/- ##
===========================================
- Coverage 67.11% 67.07% -0.04%
===========================================
Files 360 362 +2
Lines 50357 51073 +716
Branches 5665 5837 +172
===========================================
+ Hits 33795 34255 +460
- Misses 13013 13157 +144
- Partials 3549 3661 +112
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@jerenkrantz related work has been merged, conflicts look simple to resolve as this is now a gfx1033 only addition so please revise PR title and after resolving conflicts I can push for quicker review and merge |
|
@jerenkrantz appears all this has been merged already on Tensile side. Thus this can be closed and please go ahead with rocblas side changes. |
|
Work already integrated into develop so closing out, thanks for the contribution. |
Motivation
Fix TheRock build when
gfx103X-allis specified.rocBLAS build fails with error due to missing
gfx1036in Tensile CMake.Technical Details
Similar to PR #1477 (where it was for
gfx1032), it appears thatgfx1036is defined inTheRock CMake as a valid target but it isn't in Tensile.
(Of note, this PR doesn't include the test changes like #1477; if this PR looks good, I'm
happy to update the PR!)
Test Plan
Re-run cmake build of TheRock.
Test Result
rocBLAS is able to compile after applying this change.
Submission Checklist