[Tensile] Fix gfx1032 missing in SupportedISA#1477
Merged
Conversation
bstefanuk
previously approved these changes
Sep 15, 2025
amd-nicknick
force-pushed
the
users/nicknick/tensile_gfx1032_isa_missing
branch
from
4ae69b0 to
09fe264
Compare
bstefanuk
reviewed
Sep 18, 2025
Contributor
There was a problem hiding this comment.
Looking at this closer, the issue I believe is that we've added a new gfx target, but haven't properly skipped tests that are intended for other devices. Please see #697 and note that skip-gfx1032 should be added to the relevant tests.
After these are added, I recommend running the tests locally before pushing to ensure everything passes. Though, it is curious that tests only failed for gfx90a and gfx908.
amd-nicknick
force-pushed
the
users/nicknick/tensile_gfx1032_isa_missing
branch
from
21e1ded to
a6ac62f
Compare
gfx1032 is declared as supported in CMake and header files, but it is missing in Tensile Python AsmCaps and SupportedISA. This causes error when running TensileCreateLibrary with --verify-manifest --lazy-library-loading. Link: ROCm/TheRock#1260
amd-nicknick
force-pushed
the
users/nicknick/tensile_gfx1032_isa_missing
branch
from
a6ac62f to
7d65b11
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #1477 +/- ##
============================================
- Coverage 81.75% 67.00% -14.75%
============================================
Files 378 360 -18
Lines 31130 50468 +19338
Branches 0 5683 +5683
============================================
+ Hits 25450 33816 +8366
- Misses 5680 13098 +7418
- Partials 0 3554 +3554
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…e list with sequence Fix incorrect escape string in Python tests
Contributor
|
CI issues are known issues with Tensile @amd-nicknick will continue to resolve these test errors. |
assistant-librarian Bot
pushed a commit
to ROCm/Tensile
that referenced
this pull request
Sep 25, 2025
[Tensile] Fix gfx1032 missing in SupportedISA ## Motivation gfx1032 is declared as supported in CMake and header files, but it is missing in Tensile Python AsmCaps and SupportedISA. This causes error when running TensileCreateLibrary with --verify-manifest --lazy-library-loading. Link: ROCm/TheRock#1260 ## Technical Details The master file generation logic ignores any ISA that is not listed in SupportedISA, but the manifest emits the entries anyways. This causes problem with --verify-manifest when checking if all files listed in manifest are correctly generated. This issue only occurs with --lazy-library-loading, as without this flag, Tensile wouldn't generate master logic files. Rest of the logic files are generated correctly for gfx1032. ## Test Plan Test generating gfx1032 Tensile library. ``` TensileCreateLibrary --merge-files --separate-architectures --lazy-library-loading --no-short-file-names --verbose=0 --code-object-version=default --library-format=msgpack --architecture=gfx1030_gfx1032 --no-enumerate rocblas/library/src/blas3/Tensile/Logic/asm_full build/Tensile HIP --verify-manifest" ``` ## Test Result Command completes successfully with all library files emitted correctly. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
|
Github action triggered OSDB jenkins job: http://rocm-ci.amd.com/job/compute-rocm-dkms-mathlibs-osdb/377 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gfx1032 is declared as supported in CMake and header files, but it is missing in Tensile Python AsmCaps and SupportedISA. This causes error when running TensileCreateLibrary with --verify-manifest --lazy-library-loading.
Link: ROCm/TheRock#1260
Technical Details
The master file generation logic ignores any ISA that is not listed in SupportedISA, but the manifest emits the entries anyways. This causes problem with --verify-manifest when checking if all files listed in manifest are correctly generated.
This issue only occurs with --lazy-library-loading, as without this flag, Tensile wouldn't generate master logic files.
Rest of the logic files are generated correctly for gfx1032.
Test Plan
Test generating gfx1032 Tensile library.
Test Result
Command completes successfully with all library files emitted correctly.
Submission Checklist