[hipFFT] Remove conditional from body of test's target_include_directories cmake clause#1381
Merged
Merged
Conversation
regan-amd
changed the title
evetsso
reviewed
Aug 28, 2025
evetsso
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe such conditionals cannot be used within
target_include_directories.Current build lines on
develop(when building hipfft's and its clients) are polluted, e.g. see the parts between**delimiters in the copy-pasted following example:/opt/rocm/llvm/bin/amdclang++ -DUSE_HIPRAND -DUSE_PROF_API=1 -D__HIP_PLATFORM_AMD__=1 -I/src/rocm-libraries/projects/hipfft/clients/tests/**if -I"/src/rocm-libraries/projects/hipfft/clients/tests/(" -I/src/rocm-libraries/projects/hipfft/clients/tests/HIPFFT_BUILD_SCOPE -I"/src/rocm-libraries/projects/hipfft/clients/tests/)" -I/src/rocm-libraries/projects/hipfft/clients/tests/../../library/include -I/src/rocm-libraries/projects/hipfft/clients/tests/endif** -I/src/rocm-libraries/projects/hipfft/library/include -I/src/rocm-libraries/projects/hipfft/build/include/hipfft -I/src/rocm-libraries/projects/hipfft/build/include [...]I also think it's not necessary to explicitly add the intended inclusion to the
cmakelogic, as mentioned in that comment.