From 8e213de97b21855b894234d40bec27b59efc5df6 Mon Sep 17 00:00:00 2001 From: Daniel Hernandez-Juarez Date: Wed, 25 Sep 2024 13:03:18 +0000 Subject: [PATCH] Update comment regarding barrier gfx908 hack: revert scheduling region when https://github.com/llvm/llvm-project/issues/109294 is fixed --- .../mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp b/external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp index 35d597dbee4f..8cda8bf6ed7f 100644 --- a/external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp +++ b/external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp @@ -288,9 +288,8 @@ struct LDSBarrierOpLowering : public ConvertOpToLLVMPattern { auto asmDialectAttr = LLVM::AsmDialectAttr::get(rewriter.getContext(), LLVM::AsmDialect::AD_ATT); Location loc = op->getLoc(); - // Ensure the inlineAsm is guarded with a scheduling region - // So it will not interfere with backend compilation more than - // it needs. + // Revert scheduling region when + // https://github.com/llvm/llvm-project/issues/109294 is fixed rewriter.create( loc, amdgpu::sched_barrier_opt_enum::none); const char *asmStr =