Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Remove hipify as a build dependency. #1465

Open
trixirt opened this issue Dec 17, 2024 · 3 comments
Open

[Feature]: Remove hipify as a build dependency. #1465

trixirt opened this issue Dec 17, 2024 · 3 comments

Comments

@trixirt
Copy link

trixirt commented Dec 17, 2024

Suggestion Description

hipify is only needed to run when the nccl codebase is updated.
Can hipify be moved to a maintainers options and a ci system generate/commit the hipified code ?
This would reduce the complexity and speed up the build.

Operating System

ALL

GPU

ALL

ROCm Component

RCCL

@IMbackK
Copy link

IMbackK commented Dec 17, 2024

yeah i second this, its pretty silly having to use hipify at compiletime on a first party lib.

@nileshnegi
Copy link
Collaborator

we'll look into this hipified-code-only approach.
however, most of the build time is spent in the linking stage... let us know if you measured something different.
also, you can reduce build time by building only for local GPU architecture using ./install.sh -l

@IMbackK
Copy link

IMbackK commented Dec 17, 2024

For me this would be more about the benefit of a lessened dependency and the complexity of having to debug the hipifyed code while going back and forth between the original cuda and the generated hip.

The compile time is not a factor for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants