Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adjust CI to include quick start installer script #407

Closed
wyphan opened this issue Oct 15, 2024 · 1 comment
Closed

[Feature]: Adjust CI to include quick start installer script #407

wyphan opened this issue Oct 15, 2024 · 1 comment

Comments

@wyphan
Copy link

wyphan commented Oct 15, 2024

Suggestion Description

For some reason, the CI-built rocm-6.2.2 release tag doesn't include the omnitrace-install.py script as one of the release artifacts. This tag is newer than the Omnitrace v1.12.0 release tag, which properly has the script. Now, this becomes an issue because the quick start installation guide in both README.md and the docs relies on downloading the script from the "latest" tag. At the time of writing, the URL is broken because "latest" points to "rocm-6.2.2", and the script is missing on that release tag.

It would be a good idea to adjust the ROCm CI release bot to include and/or generate the omnitrace-install.py script.

Operating System

No response

GPU

No response

ROCm Component

No response

@dgaliffiAMD
Copy link
Collaborator

Thanks, @wyphan .
This should be fixed with #400. Our next release from rocm-6.2.x should work as expected.
Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants