diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f708be607..1ba2bead9b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log for hipBLASLt -## (Unreleased) hipBLASLt 1.0.0 +## (Unreleased) hipBLASLt 0.1.0 ### Added - Enable hipBLASLt APIs - Support gfx90a diff --git a/CMakeLists.txt b/CMakeLists.txt index ae5dddceba..90c733403c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -228,7 +228,7 @@ endif() find_package( hipblas 0.50.0 REQUIRED CONFIG PATHS ${HIP_DIR} ${ROCM_PATH} /opt/rocm) # Setup version -set(VERSION_STRING "0.0.7") +set(VERSION_STRING "0.1.0") rocm_setup_version(VERSION ${VERSION_STRING}) set(hipblaslt_SOVERSION 0.1) diff --git a/docs/source/install.rst b/docs/source/install.rst index cf71d7f400..bddc5baaed 100644 --- a/docs/source/install.rst +++ b/docs/source/install.rst @@ -154,7 +154,7 @@ Build Library Using Individual Commands cd [HIPBLASLT_BUILD_DIR]/release # Default install location is in /opt/rocm, define -DCMAKE_INSTALL_PREFIX= to specify other # Default build config is 'Release', define -DCMAKE_BUILD_TYPE= to specify other - CXX=/opt/rocm/bin/hipcc ccmake [HIPBLAS_SOURCE] + CXX=/opt/rocm/bin/hipcc ccmake [HIPBLASLT_SOURCE] make -j$(nproc) sudo make install # sudo required if installing into system directory such as /opt/rocm @@ -172,14 +172,14 @@ The hipBLASLt samples have no external dependencies, but our unit test and bench - `lapack `_, lapack itself brings a dependency on a fortran compiler - `googletest `_ -Unfortunately, googletest and lapack are not as easy to install. Many distros do not provide a googletest package with pre-compiled libraries, and the lapack packages do not have the necessary cmake config files for cmake to configure linking the cblas library. hipBLAS provide a cmake script that builds the above dependencies from source. This is an optional step; users can provide their own builds of these dependencies and help cmake find them by setting the CMAKE_PREFIX_PATH definition. The following is a sequence of steps to build dependencies and install them to the cmake default /usr/local. +Unfortunately, googletest and lapack are not as easy to install. Many distros do not provide a googletest package with pre-compiled libraries, and the lapack packages do not have the necessary cmake config files for cmake to configure linking the cblas library. hipBLASLt provide a cmake script that builds the above dependencies from source. This is an optional step; users can provide their own builds of these dependencies and help cmake find them by setting the CMAKE_PREFIX_PATH definition. The following is a sequence of steps to build dependencies and install them to the cmake default /usr/local. (optional, one time only) ~~~~~~~~~~~~~~~~~~~~~~~~~ .. code-block::bash mkdir -p [HIPBLASLT_BUILD_DIR]/release/deps cd [HIPBLASLT_BUILD_DIR]/release/deps - ccmake -DBUILD_BOOST=OFF [HIPBLAS_SOURCE]/deps # assuming boost is installed through package manager as above + ccmake -DBUILD_BOOST=OFF [HIPBLASLT_SOURCE]/deps # assuming boost is installed through package manager as above make -j$(nproc) install Once dependencies are available on the system, it is possible to configure the clients to build. This requires a few extra cmake flags to the library cmake configure script. If the dependencies are not installed into system defaults (like /usr/local ), you should pass the CMAKE_PREFIX_PATH to cmake to help find them. diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt index 66b56e7f4a..102faf24c9 100644 --- a/library/CMakeLists.txt +++ b/library/CMakeLists.txt @@ -39,7 +39,7 @@ configure_file("${CMAKE_CURRENT_SOURCE_DIR}/include/hipblaslt-version.h.in" configure_file( "${CMAKE_CURRENT_SOURCE_DIR}/include/hipblaslt.h" "${PROJECT_BINARY_DIR}/include/hipblaslt/hipblaslt.h" COPYONLY) configure_file( "${CMAKE_CURRENT_SOURCE_DIR}/include/hipblaslt-types.h" "${PROJECT_BINARY_DIR}/include/hipblaslt/hipblaslt-types.h" COPYONLY) -# Public hipBLAS headers +# Public hipBLASLt headers set(hipblaslt_headers_public include/hipblaslt.h ${PROJECT_BINARY_DIR}/include/hipblaslt/hipblaslt-version.h @@ -74,7 +74,7 @@ if( BUILD_WITH_TENSILE ) # bypassing cmake dependencies chain for static link as it won't allow target from different directory - # including tensile headers into hipblas tensileHost client so get compile properties + # including tensile headers into hipblaslt tensileHost client so get compile properties get_target_property(TensileHost_INCLUDES TensileHost INCLUDE_DIRECTORIES) target_include_directories( hipblaslt PRIVATE ${TensileHost_INCLUDES} ) get_target_property(TensileHost_DEFINES TensileHost COMPILE_DEFINITIONS) diff --git a/library/src/amd_detail/hipblaslt.cpp b/library/src/amd_detail/hipblaslt.cpp index 93a4b1ee49..1bf9c10397 100644 --- a/library/src/amd_detail/hipblaslt.cpp +++ b/library/src/amd_detail/hipblaslt.cpp @@ -414,7 +414,7 @@ catch(...) hipblasStatus_t hipblasLtGetGitRevision(hipblasLtHandle_t handle, char* rev) try { - // Get hipBLAS revision + // Get hipBLASLt revision if(handle == nullptr) { return HIPBLAS_STATUS_NOT_INITIALIZED;