removed 64-bit gemv test#832
Closed
NaveenElumalaiAMD wants to merge 0 commit into
Closed
Conversation
NaveenElumalaiAMD
requested review from
TorreZuk,
amcamd,
bragadeesh,
daineAMD,
mahmoodw and
rkamd
as code owners
TorreZuk
approved these changes
Mar 27, 2024
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
LGTM, but was gemv_64 tested for small sizes?
Contributor
Author
I added that to test a PR to see if we are skipping the tests if host memory allocation is exceeds available memory. gemv ILP64 is checked in bad_arg test. |
daineAMD
approved these changes
Apr 1, 2024
NaveenElumalaiAMD
force-pushed
the
remove-64-bit-test
branch
from
eb44cbe to
545a9b6
Compare
NaveenElumalaiAMD
force-pushed
the
remove-64-bit-test
branch
from
545a9b6 to
77001fc
Compare
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
[hipBLAS] Add Clang guards around usage of openmp config (#1050) (#832) This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. [ROCm/hipBLAS commit: 4639103] This patch is dependent on the Ubuntu 24.04 docker file being updated to use AOCL 4.2 instead of 4.0. Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.