Conversation
asroy
approved these changes
Mar 1, 2023
carlushuang
pushed a commit
that referenced
this pull request
Mar 6, 2023
* suppress the reserved-identifier warnings * keep BUILD_DEV=On and use -Werror by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the recent changes has triggered a "reserved-identifier" warning that currently can't be eliminated by any means other then just getting suppressed. Also, we need to start catching any new warnings during the CI process, so I've enabled the -Werror and BUILD_DEV=ON compiler options.