Use Space Filling Curve in Threadwise Copy#118
Merged
Conversation
Contributor
|
I found no issue while testing this P.R with Reduction |
Contributor
|
Please fix merge conflict |
1 similar comment
Contributor
|
Please fix merge conflict |
j4yan
force-pushed
the
fix_threadwise_copy_error_in_reduction
branch
from
2ba9e3e to
b29dfd7
Compare
Contributor
Author
|
Done. |
asroy
previously approved these changes
Mar 10, 2022
asroy
reviewed
Mar 10, 2022
added 2 commits
March 10, 2022 16:29
…y_error_in_reduction
asroy
changed the title
asroy
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added case
SpaceFillingCurve::GetNumAccess()=0inGetCoordinateResetStepdidn't deal with the case whereSpaceFillingCurve::GetNumAccess()=0, which caused the reversion #111This PR should resolve the issue.