Skip to content

Introduce wrapper library#1071

Merged
bartekxk merged 6 commits into
developfrom
barkocot/lwpck-1063-dev
Dec 6, 2023
Merged

Introduce wrapper library#1071
bartekxk merged 6 commits into
developfrom
barkocot/lwpck-1063-dev

Conversation

@bartekxk
Copy link
Copy Markdown
Contributor

@bartekxk bartekxk commented Nov 30, 2023

@bartekxk bartekxk self-assigned this Nov 30, 2023
@bartekxk bartekxk requested a review from aosewski November 30, 2023 18:39
Comment thread docs/index.rst Outdated
Comment thread docs/wrapper.rst Outdated
Comment thread docs/wrapper.rst Outdated
Comment thread include/ck/wrapper/layout.hpp Outdated
Comment thread include/ck/wrapper/layout.hpp
Comment thread include/ck/wrapper/layout.hpp Outdated
Comment thread include/ck/wrapper/layout.hpp
Comment thread test/wrapper/test_layout.cpp Outdated
@bartekxk bartekxk requested a review from aosewski December 5, 2023 12:58
}

// Merge nested shape dims
// Merge nested shape dims. Merge nested shape dims when idx is also nested.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Merge nested shape dims. Merge nested shape dims when idx is also nested.
// Merge nested shape dims when corresponding index is also nested.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in next PR, thanks

@bartekxk bartekxk merged commit 836b7e5 into develop Dec 6, 2023
@bartekxk bartekxk deleted the barkocot/lwpck-1063-dev branch December 14, 2023 23:43
asroy pushed a commit that referenced this pull request Dec 18, 2023
* Introduce wrapper library

* Update cmake files

* Revert "Update cmake files"

This reverts commit c27f88b.

* Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants