diff --git a/csrc/include/custom_all_reduce.cuh b/csrc/include/custom_all_reduce.cuh index 589179918b..de4ee62da9 100644 --- a/csrc/include/custom_all_reduce.cuh +++ b/csrc/include/custom_all_reduce.cuh @@ -467,6 +467,7 @@ __global__ void __launch_bounds__(512, 1) cross_device_reduce_1stage(RankData* _ buf = next_buf; } + end_sync(sg, self_sg, rank); } template @@ -698,6 +699,7 @@ __global__ void __launch_bounds__(512, 1) allgather_naive( int write_idx = warp_id * size + idx; result[write_idx] = ptrs[warp_id][idx]; } + end_sync(sg, self_sg, rank); } template @@ -725,6 +727,7 @@ __global__ void __launch_bounds__(512, 1) allgather_vec( int write_idx = warp_id * size + idx; *(reinterpret_cast(&result[0]) + write_idx) = ptrs[warp_id][idx]; } + end_sync(sg, self_sg, rank); } template @@ -761,6 +764,7 @@ __global__ void __launch_bounds__(512, 1) allgather_lastdim(RankData* _dp, int write_idx = (ngpus * y + warp_id) * last_dim_size + x; *(reinterpret_cast(&result[0]) + write_idx) = ptrs[warp_id][idx]; } + end_sync(sg, self_sg, rank); } /* @@ -796,6 +800,7 @@ __global__ void __launch_bounds__(512, 1) reduce_scatter_first_dim( *(reinterpret_cast(result) + store_index) = packed_reduce(ptrs, load_index); } + end_sync(sg, self_sg, rank); } // fp8 quant all-reduce code start