From f43eedd360114a389d916f6e21ad2fc129099726 Mon Sep 17 00:00:00 2001 From: Minseob Shin Date: Thu, 16 Jul 2026 17:07:34 +0000 Subject: [PATCH 1/2] ci: add no_rocm_image_ubuntu24_04_openmpi test image --- .../workflows/publish_no_rocm_image_ubuntu24_04.yml | 9 +++++++++ dockerfiles/README.md | 10 ++++++++++ .../no_rocm_image_ubuntu24_04_openmpi.Dockerfile | 12 ++++++++++++ 3 files changed, 31 insertions(+) create mode 100644 dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile diff --git a/.github/workflows/publish_no_rocm_image_ubuntu24_04.yml b/.github/workflows/publish_no_rocm_image_ubuntu24_04.yml index dd127135efb..eaecce9bdb6 100644 --- a/.github/workflows/publish_no_rocm_image_ubuntu24_04.yml +++ b/.github/workflows/publish_no_rocm_image_ubuntu24_04.yml @@ -47,3 +47,12 @@ jobs: with: DOCKER_FILE_NAME: no_rocm_image_ubuntu24_04_media DOCKER_IMAGE_NAME: no_rocm_image_ubuntu24_04_media + # The image no_rocm_image_ubuntu24_04_openmpi is an extension of + # no_rocm_image_ubuntu24_04, so make sure we rebuild the _openmpi + # version whenever the base version changes. + publish_no_rocm_image_ubuntu24_04_openmpi: + needs: [publish_no_rocm_image_ubuntu24_04] + uses: ./.github/workflows/publish_dockerfile.yml + with: + DOCKER_FILE_NAME: no_rocm_image_ubuntu24_04_openmpi + DOCKER_IMAGE_NAME: no_rocm_image_ubuntu24_04_openmpi diff --git a/dockerfiles/README.md b/dockerfiles/README.md index d1237487f69..2e1ba99b08d 100644 --- a/dockerfiles/README.md +++ b/dockerfiles/README.md @@ -100,6 +100,16 @@ This includes dejagnu, make, gcc, g++ and gfortran. Used in ocltst execution. It installs OCL ICD package required by ocltst +| Source .Dockerfile | Published package | +| ---------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------- | +| [`no_rocm_image_ubuntu24_04_openmpi.Dockerfile`](no_rocm_image_ubuntu24_04_openmpi.Dockerfile) | https://github.com/ROCm/TheRock/pkgs/container/no_rocm_image_ubuntu24_04_openmpi | + +Extended version of no_rocm_image_ubuntu24_04.Dockerfile, containing a system +OpenMPI install (`libopenmpi-dev`, `openmpi-bin`) required to build and run the +rocprofv3 `mpi-ranks` integration tests. OpenMPI is intentionally not bundled in +TheRock artifacts (to avoid forcing a specific MPI onto users), so it is provided +at the system level here for the test environment. + ### `rocm_runtime.Dockerfile` | Source .Dockerfile | Published package | diff --git a/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile b/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile new file mode 100644 index 00000000000..0894964e58d --- /dev/null +++ b/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile @@ -0,0 +1,12 @@ +FROM ghcr.io/rocm/no_rocm_image_ubuntu24_04:latest + +# no_rocm_image_ubuntu24_04_openmpi: +# Extend the base no_rocm_image_ubuntu24_04 image with a system OpenMPI install +# required to build and run the rocprofv3 mpi-ranks integration tests. OpenMPI is +# intentionally not bundled in TheRock artifacts (to avoid forcing a specific MPI +# onto users), so it is provided at the system level for the test environment. The +# corresponding published image is: +# ghcr.io/rocm/no_rocm_image_ubuntu24_04_openmpi:latest +RUN sudo apt-get install -y --no-install-recommends \ + libopenmpi-dev \ + openmpi-bin From 412dd692d69eb755dbc0626c0fedbe5461c9d3d1 Mon Sep 17 00:00:00 2001 From: Minseob Shin Date: Mon, 20 Jul 2026 14:24:01 +0000 Subject: [PATCH 2/2] clarify comments --- dockerfiles/README.md | 11 +++++++---- .../no_rocm_image_ubuntu24_04_openmpi.Dockerfile | 12 +++++++----- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/dockerfiles/README.md b/dockerfiles/README.md index 2e1ba99b08d..9d55665676a 100644 --- a/dockerfiles/README.md +++ b/dockerfiles/README.md @@ -105,10 +105,13 @@ by ocltst | [`no_rocm_image_ubuntu24_04_openmpi.Dockerfile`](no_rocm_image_ubuntu24_04_openmpi.Dockerfile) | https://github.com/ROCm/TheRock/pkgs/container/no_rocm_image_ubuntu24_04_openmpi | Extended version of no_rocm_image_ubuntu24_04.Dockerfile, containing a system -OpenMPI install (`libopenmpi-dev`, `openmpi-bin`) required to build and run the -rocprofv3 `mpi-ranks` integration tests. OpenMPI is intentionally not bundled in -TheRock artifacts (to avoid forcing a specific MPI onto users), so it is provided -at the system level here for the test environment. +OpenMPI install (`libopenmpi-dev`, `openmpi-bin`) for the rocprofv3 `mpi-ranks` +integration tests. Like the other `no_rocm_image_*` images this is a test-only +image (not a ROCm build image): the rocprofiler-sdk tests are configured and +compiled in-container at test time, so `find_package(MPI)` needs the OpenMPI +headers and `mpiexec`. OpenMPI is intentionally not bundled in TheRock artifacts +(to avoid forcing a specific MPI onto users), so it is provided at the system +level here for the test environment. ### `rocm_runtime.Dockerfile` diff --git a/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile b/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile index 0894964e58d..3cdf3f25639 100644 --- a/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile +++ b/dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile @@ -1,11 +1,13 @@ FROM ghcr.io/rocm/no_rocm_image_ubuntu24_04:latest # no_rocm_image_ubuntu24_04_openmpi: -# Extend the base no_rocm_image_ubuntu24_04 image with a system OpenMPI install -# required to build and run the rocprofv3 mpi-ranks integration tests. OpenMPI is -# intentionally not bundled in TheRock artifacts (to avoid forcing a specific MPI -# onto users), so it is provided at the system level for the test environment. The -# corresponding published image is: +# Test-only image (not a ROCm build image): extends no_rocm_image_ubuntu24_04 with +# a system OpenMPI install (libopenmpi-dev, openmpi-bin) for the rocprofv3 mpi-ranks +# integration tests. The rocprofiler-sdk tests are configured and compiled +# in-container at test time, so find_package(MPI) needs the OpenMPI headers and +# mpiexec. OpenMPI is intentionally not bundled in TheRock artifacts (to avoid +# forcing a specific MPI onto users), so it is provided at the system level here. +# The corresponding published image is: # ghcr.io/rocm/no_rocm_image_ubuntu24_04_openmpi:latest RUN sudo apt-get install -y --no-install-recommends \ libopenmpi-dev \